Re: [RFC PATCH v1 37/38] coco: guest: arm64: Add support for fetching device measurements

Jonathan Cameron
2025-07-31T10:17:07Z

On Mon, 28 Jul 2025 19:22:14 +0530
"Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org> wrote:

> Fetch device measurements using RSI_RDEV_GET_MEASUREMENTS.
>
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
One completely trivial comment.

J
> diff --git a/drivers/virt/coco/arm-cca-guest/rsi-da.c b/drivers/virt/coco/arm-cca-guest/rsi-da.c
> index 64034d220e02..6222b10964ee 100644
> --- a/drivers/virt/coco/arm-cca-guest/rsi-da.c
> +++ b/drivers/virt/coco/arm-cca-guest/rsi-da.c

> @@ -213,6 +245,13 @@ int rsi_device_lock(struct pci_dev *pdev)
> return -EIO;
> }
>
> + ret = rhi_get_report(vdev_id, RHI_DA_OBJECT_MEASUREMENT,
> + &dsm->measurements, &dsm->measurements_size);
> + if (ret) {
> + pci_err(pdev, "failed to get device certificate from the host (%lu)\n", ret);
> + return -EIO;
> + }
> +
> return ret;

return 0; Always good to make it explicit when it can't take any other values.
Looks like that belong sin an earlier patch though based on this snippet.

> }