Re: [RFC PATCH v1 21/38] coco: host: arm64: Add support for virtual device communication

Aneesh Kumar K.V
2025-08-04T04:45:19Z

Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:

> On Mon, 28 Jul 2025 19:21:58 +0530
> "Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org> wrote:
>
>> Add support for vdev_communicate with RMM.
>>
>> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>
>
> One minor comment.
>
>> diff --git a/drivers/virt/coco/arm-cca-host/rmm-da.c b/drivers/virt/coco/arm-cca-host/rmm-da.c
>> index 41314db1d568..8635f361bbe8 100644
>> --- a/drivers/virt/coco/arm-cca-host/rmm-da.c
>> +++ b/drivers/virt/coco/arm-cca-host/rmm-da.c
>> @@ -207,8 +207,14 @@ static int __do_dev_communicate(int type, struct pci_tsm *tsm)
>
> Can type parameter be an enum so we can see all cases are covered?
>

Sure, will update the patch

>
>> if (type == PDEV_COMMUNICATE)
>> ret = rmi_pdev_communicate(virt_to_phys(dsc_pf0->rmm_pdev),
>> virt_to_phys(comm_data->io_params));
>> - else
>> - ret = RMI_ERROR_INPUT;
>> + else {
>> + struct cca_host_tdi *host_tdi = container_of(tsm->tdi, struct cca_host_tdi, tdi);
>> +
>> + ret = rmi_vdev_communicate(virt_to_phys(dsc_pf0->rmm_pdev),
>> + virt_to_phys(host_tdi->rmm_vdev),
>> + virt_to_phys(comm_data->io_params));
>> + }

-aneesh