The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, Frank Li <Frank.Li@nxp.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Nam Cao <namcao@linutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Nicolas Frayer <nfrayer@baylibre.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Stanimir Varbanov <svarbanov@suse.de>,
	Inochi Amaoto <inochiama@gmail.com>,
	Chen Wang <unicorn_wang@outlook.com>,
	Lukas Bulwahn <lukas.bulwahn@redhat.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] [v2] irqchip: build IMX_MU_MSI only on ARM
Date: Tue,  5 Aug 2025 18:09:49 +0200	[thread overview]
Message-ID: <20250805160952.4006075-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

compile-testing IMX_MU_MSI on x86 without PCI_MSI support results
in a build failure:

drivers/gpio/gpio-sprd.c:8:
include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
drivers/iommu/iommufd/viommu.c:4:
include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type

Tighten the dependency further to only allow compile testing on Arm.
This could be refined further to allow certain x86 configs.

I submitted this patch before to address a different build failure, which
was fixed independently but has now returned.

Link: https://lore.kernel.org/all/20221215164109.761427-1-arnd@kernel.org/
Fixes: 70afdab904d2d1e6 ("irqchip: Add IMX MU MSI controller driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

It seems to be a recurring problem wiht x86 not using CONFIG_GENERIC_MSI_IRQ,
while all other architectures do. I wonder if that is something that
should be changed by changing the x86 irqchip implementation so that
CONFIG_GENERIC_MSI_IRQ can become the only way to do MSI.
---
 drivers/irqchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 96cca93714ef..b0b7143cae2d 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -558,6 +558,7 @@ config IMX_MU_MSI
 	tristate "i.MX MU used as MSI controller"
 	depends on OF && HAS_IOMEM
 	depends on ARCH_MXC || COMPILE_TEST
+	depends on ARM || ARM64
 	default m if ARCH_MXC
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
-- 
2.39.5


             reply	other threads:[~2025-08-05 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05 16:09 Arnd Bergmann [this message]
2025-08-06  8:33 ` [PATCH] [v2] irqchip: build IMX_MU_MSI only on ARM Thomas Gleixner
2025-08-06  8:44 ` [tip: irq/urgent] irqchip: Build " tip-bot2 for Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250805160952.4006075-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=arnd@arndb.de \
    --cc=geert+renesas@glider.be \
    --cc=inochiama@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=lukas.bulwahn@redhat.com \
    --cc=maz@kernel.org \
    --cc=namcao@linutronix.de \
    --cc=nfrayer@baylibre.com \
    --cc=pbrobinson@gmail.com \
    --cc=svarbanov@suse.de \
    --cc=tglx@linutronix.de \
    --cc=unicorn_wang@outlook.com \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox