From: Jakub Kicinski <kuba@kernel.org>
To: tglx@linutronix.de
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Jeongjun Park <aha310510@gmail.com>,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
yangbo.lu@nxp.com, anna-maria@linutronix.de, frederic@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+7cfb66a237c4a5fb22ad@syzkaller.appspotmail.com
Subject: Re: [PATCH net v4] ptp: prevent possible ABBA deadlock in ptp_clock_freerun()
Date: Tue, 5 Aug 2025 16:52:26 -0700 [thread overview]
Message-ID: <20250805165226.5e52e8a9@kernel.org> (raw)
In-Reply-To: <20250729154811.a7lg26iuszzoo2sp@skbuf>
On Tue, 29 Jul 2025 18:48:11 +0300 Vladimir Oltean wrote:
> > +static void ptp_vclock_set_subclass(struct ptp_clock *ptp)
> > +{
> > + lockdep_set_subclass(&ptp->clock.rwsem, PTP_LOCK_VIRTUAL);
>
> Just not sure whether the PTP clock should be exposing this API, or the
> POSIX clock, who actually owns the rwsem.
Hi Thomas, how do you feel about PTP setting lockdep class on the clock
rwsem? Link: https://lore.kernel.org/20250728062649.469882-1-aha310510@gmail.com
next prev parent reply other threads:[~2025-08-05 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 6:26 [PATCH net v4] ptp: prevent possible ABBA deadlock in ptp_clock_freerun() Jeongjun Park
2025-07-28 14:09 ` Richard Cochran
2025-07-29 15:48 ` Vladimir Oltean
2025-08-05 23:52 ` Jakub Kicinski [this message]
2025-08-24 3:23 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805165226.5e52e8a9@kernel.org \
--to=kuba@kernel.org \
--cc=aha310510@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=syzbot+7cfb66a237c4a5fb22ad@syzkaller.appspotmail.com \
--cc=tglx@linutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).