From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <liuyonglong@huawei.com>,
<chenhao418@huawei.com>, <jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net 2/3] net: hibmcge: fix the division by zero issue
Date: Tue, 5 Aug 2025 18:14:46 -0700 [thread overview]
Message-ID: <20250805181446.3deaceb9@kernel.org> (raw)
In-Reply-To: <20250802123226.3386231-3-shaojijie@huawei.com>
On Sat, 2 Aug 2025 20:32:25 +0800 Jijie Shao wrote:
> static inline u32 hbg_get_queue_used_num(struct hbg_ring *ring)
> {
> + if (!ring->len)
> + return 0;
> +
> return (ring->ntu + ring->len - ring->ntc) % ring->len;
This should probably be a READ_ONCE() to a temporary variable.
There is no locking in debugfs, AFAICT, the value may change
between the test and the division / modulo.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-06 1:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 12:32 [PATCH V2 net 0/3] There are some bugfix for hibmcge ethernet driver Jijie Shao
2025-08-02 12:32 ` [PATCH V2 net 1/3] net: hibmcge: fix rtnl deadlock issue Jijie Shao
2025-08-05 9:03 ` Simon Horman
2025-08-02 12:32 ` [PATCH V2 net 2/3] net: hibmcge: fix the division by zero issue Jijie Shao
2025-08-06 1:14 ` Jakub Kicinski [this message]
2025-08-06 4:00 ` Jijie Shao
2025-08-02 12:32 ` [PATCH V2 net 3/3] net: hibmcge: fix the np_link_fail error reporting issue Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805181446.3deaceb9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).