From: Greg KH <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Zhen Ni <zhen.ni@easystack.cn>,
linux-acpi@vger.kernel.org, stable@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v4] mailbox: pcc: Add missed acpi_put_table() to fix memory leak
Date: Tue, 5 Aug 2025 08:26:08 +0100 [thread overview]
Message-ID: <2025080552-stubbly-elliptic-6fa0@gregkh> (raw)
In-Reply-To: <41fdbd2b-92c5-4f11-9c58-aff9b9f35e72@web.de>
On Tue, Aug 05, 2025 at 08:28:17AM +0200, Markus Elfring wrote:
> > Fixes a permanent ACPI memory leak in the success path by adding
> > acpi_put_table().
> > Renaming generic 'err' label to 'put_table' for clarity.
>
> Will a desire grow for the usage of imperative mood also in such change descriptions?
>
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
>
>
> …> Changes in v4:
> > - Change goto target from err to put_table.
>
> Thanks.
>
>
> > - Remove goto tatget err_nomem
> …
>
> Does this adjustment indicate questionable development difficulties?
>
> Regards,
> Markus
>
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2025-08-05 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730124508.939257-1-zhen.ni@easystack.cn>
2025-08-01 14:35 ` [PATCH] mailbox: pcc: Add missed acpi_put_table() to fix memory leak Markus Elfring
[not found] ` <20250804074115.44573-1-zhen.ni@easystack.cn>
2025-08-04 8:42 ` [PATCH v2] " Markus Elfring
[not found] ` <20250804121453.75525-1-zhen.ni@easystack.cn>
2025-08-04 14:06 ` [PATCH v3] " Markus Elfring
[not found] ` <20250805034829.168187-1-zhen.ni@easystack.cn>
2025-08-05 6:28 ` [PATCH v4] " Markus Elfring
2025-08-05 7:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025080552-stubbly-elliptic-6fa0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).