From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E3228A1D0 for ; Wed, 6 Aug 2025 09:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754472409; cv=none; b=TrjEj2XRsW7brDDco6CwTKNNmMCvB9NLh8WqOi0aVqasrFfjuKq7UOPgX5y0VG2efovvaz7MuLQDJmvWtwE9feUbSmC0ciXkUWQl4VsawzqR55jsKRfyBf5b3uwVFAlS2TpA+h3SAMy1utAqCg6R7sT85K8E5RvyjNcEOaQ07EQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754472409; c=relaxed/simple; bh=kjgJvQfAH2HHrgLjbwIXPa5yuvPf7HX/Yn/zDJkGNbQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pxb11VNqDcYnsReB+vU/2P2AzmIa9QlciYIiaitsZiX8eqffDrDIsUk9VE2YFIYDKt+JQNRz1vRCJoG415KDW32mZUdez1ljJVVDc2xDrw3BcmKMaNITp7DPpkN0MylSavL0/th4UvmBEjcYaU5ZG6g2BwZAwabR1Wt91eoXjbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=E8C+tV0E; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="E8C+tV0E" Received: by mail.gandi.net (Postfix) with ESMTPSA id 4D8364328C; Wed, 6 Aug 2025 09:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1754472405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3cKfDdyHMTQB0ZOEVaUCAQA8xzfHBYZghz88HKp6w3c=; b=E8C+tV0EmydiZs/Af3C65XUHm3JSCG1QAvGuIkxa2aHQ3nJhHDdyXvr4XbLnfpN6s1sp0+ IQ5Pw2j2PRSzm985ZKYjbgxSLhzKzLmrtK6kcRB1XSEgbZcisAoZDL8vbSRE6Na3hIvCEA C1tRQscn/fSbyz3wdihEuPYYpFNCBZ7pcgSHbJrczK0Q6lvV/DRdoCgk6Ep/AX7/g8U3A9 hrLHgphLwEQglroPaLd/SZZ1PFMOgU5hi0XPf3dGSf/J3yGvmefVD8ao+W/ANuwM5zRFtl mqyw8v1YkbMfuQhHHslbmLPF2mkvK7H4YlI4qyZm30cbPw5JvKPEixW+ZcO83g== Date: Wed, 6 Aug 2025 11:26:41 +0200 From: Luca Ceresoli To: Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.baryshkov@oss.qualcomm.com, dianders@chromium.org, damon.ding@rock-chips.com, m.szyprowski@samsung.com Subject: Re: [PATCH] drm/bridge: analogix_dp: Fix bailout for devm_drm_bridge_alloc() Message-ID: <20250806112641.7af982e3@booty> In-Reply-To: <20250806085424.518274-1-victor.liu@nxp.com> References: <20250806085424.518274-1-victor.liu@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: 0 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduudejieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhepfffhvfevuffkjghfohfogggtgfesthejredtredtvdenucfhrhhomhepnfhutggrucevvghrvghsohhlihcuoehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeglefffefghefhtddvfeeufeeiveekgffgleekieduteekkeetvdehudekgfdvvdenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedukedprhgtphhtthhopehvihgtthhorhdrlhhiuhesnhigphdrtghomhdprhgtphhtthhopegurhhiqdguvghvvghlsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrt ghpthhtoheprghnughriigvjhdrhhgrjhgurgesihhnthgvlhdrtghomhdprhgtphhtthhopehnvghilhdrrghrmhhsthhrohhngheslhhinhgrrhhordhorhhgpdhrtghpthhtoheprhhfohhssheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepnfgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehjohhnrghssehkfihisghoohdrshgv X-GND-Sasl: luca.ceresoli@bootlin.com Hello Liu, On Wed, 6 Aug 2025 16:54:24 +0800 Liu Ying wrote: > devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a > NULL pointer, so use IS_ERR() to check the returned pointer. > > Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API") > Signed-off-by: Liu Ying > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index ed35e567d117..86cf898a09bb 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1474,7 +1474,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) > > dp = devm_drm_bridge_alloc(dev, struct analogix_dp_device, bridge, > &analogix_dp_bridge_funcs); > - if (!dp) > + if (IS_ERR(dp)) > return ERR_PTR(-ENOMEM); Good catch, thanks! You fix is correct but now I realized one additional fix is needed in the following line: - return ERR_PTR(-ENOMEM); + return ERR_PTR(dp); Can you send a v2 with that fixed? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com