[PATCH v2] memory: stm32_omm: Fix req2ack update test

[PATCH v2] memory: stm32_omm: Fix req2ack update test

[Patrice Chotard]

If "st,omm-req2ack-ns" property is found and its value is not 0,
the current test doesn't allow to compute and set req2ack value,
Fix this test.

Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver")
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
Changes in v2:
- Add more detail in commit message
- Remove "Cc: <stable@vger.kernel.org>" tag as the fixed patch is not part of a LTS.
- Link to v1: https://lore.kernel.org/r/20250806-upstream_omm_fix_req2ack_test_condition-v1-1-4879a1d7f794@foss.st.com
---
 drivers/memory/stm32_omm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/stm32_omm.c b/drivers/memory/stm32_omm.c
index 79ceb1635698f6bc8bd4a39fdeaced1ec318e1f6..9efc56a85b5ecca49eb6dfc0ef83880f89591cd1 100644
--- a/drivers/memory/stm32_omm.c
+++ b/drivers/memory/stm32_omm.c
@@ -247,7 +247,7 @@ static int stm32_omm_configure(struct device *dev)
 		if (mux & CR_MUXEN) {
 			ret = of_property_read_u32(dev->of_node, "st,omm-req2ack-ns",
 						   &req2ack);
-			if (!ret && !req2ack) {
+			if (!ret && req2ack) {
 				req2ack = DIV_ROUND_UP(req2ack, NSEC_PER_SEC / clk_rate_max) - 1;
 
 				if (req2ack > 256)

---
base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
change-id: 20250806-upstream_omm_fix_req2ack_test_condition-77e8fb0d13d8

Best regards,
-- 
Patrice Chotard <patrice.chotard@foss.st.com>

Re: [PATCH v2] memory: stm32_omm: Fix req2ack update test

[Krzysztof Kozlowski]

On 07/08/2025 09:34, Patrice Chotard wrote:
> If "st,omm-req2ack-ns" property is found and its value is not 0,
> the current test doesn't allow to compute and set req2ack value,
> Fix this test.
> 
> Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver")
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> Changes in v2:
> - Add more detail in commit message
> - Remove "Cc: <stable@vger.kernel.org>" tag as the fixed patch is not part of a LTS.

Why LTS would matter? Which kernel is being fixed here?

Best regards,
Krzysztof

Re: [PATCH v2] memory: stm32_omm: Fix req2ack update test

[Patrice CHOTARD]

On 8/11/25 09:09, Krzysztof Kozlowski wrote:
> On 07/08/2025 09:34, Patrice Chotard wrote:
>> If "st,omm-req2ack-ns" property is found and its value is not 0,
>> the current test doesn't allow to compute and set req2ack value,
>> Fix this test.
>>
>> Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver")
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> Changes in v2:
>> - Add more detail in commit message
>> - Remove "Cc: <stable@vger.kernel.org>" tag as the fixed patch is not part of a LTS.
> 
> Why LTS would matter? Which kernel is being fixed here?

Hi Krzysztof,

The fixed kernel is v6.16.

Thanks
Patrice

> 
> Best regards,
> Krzysztof

Re: [PATCH v2] memory: stm32_omm: Fix req2ack update test

[Krzysztof Kozlowski]

On 11/08/2025 14:49, Patrice CHOTARD wrote:
> 
> 
> On 8/11/25 09:09, Krzysztof Kozlowski wrote:
>> On 07/08/2025 09:34, Patrice Chotard wrote:
>>> If "st,omm-req2ack-ns" property is found and its value is not 0,
>>> the current test doesn't allow to compute and set req2ack value,
>>> Fix this test.
>>>
>>> Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver")
>>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>>> ---
>>> Changes in v2:
>>> - Add more detail in commit message
>>> - Remove "Cc: <stable@vger.kernel.org>" tag as the fixed patch is not part of a LTS.
>>
>> Why LTS would matter? Which kernel is being fixed here?
> 
> Hi Krzysztof,
> 
> The fixed kernel is v6.16.
Then you need Cc stable. Only unreleased kernels are... well, unreleased.

Fixed while applying, but your other patches might have same issue.

Best regards,
Krzysztof

Re: [PATCH v2] memory: stm32_omm: Fix req2ack update test

[Krzysztof Kozlowski]

On Thu, 07 Aug 2025 09:34:09 +0200, Patrice Chotard wrote:
> If "st,omm-req2ack-ns" property is found and its value is not 0,
> the current test doesn't allow to compute and set req2ack value,
> Fix this test.
> 
> 

Applied, thanks!

[1/1] memory: stm32_omm: Fix req2ack update test
      https://git.kernel.org/krzk/linux-mem-ctrl/c/d140f3ba76ac98faad7f9b37ef5a3dcbd57f59e2

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>