From: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Dmitry Baryshkov <lumag@kernel.org>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Yongxing Mou <quic_yongmou@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: [PATCH v2 09/12] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug handler
Date: Fri, 08 Aug 2025 17:35:21 -0700 [thread overview]
Message-ID: <20250808-hpd-refactor-v2-9-7f4e1e741aa3@oss.qualcomm.com> (raw)
In-Reply-To: <20250808-hpd-refactor-v2-0-7f4e1e741aa3@oss.qualcomm.com>
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
In commit 8ede2ecc3e5ee ("drm/msm/dp: Add DP compliance tests on Snapdragon
Chipsets"), checks were introduced to avoid handling any plug event in
ST_DISPLAY_OFF state.
Even if we do get hpd events, after the bridge was disabled,
it should get handled. Moreover, its unclear under what circumstances
these events will fire because ST_DISPLAY_OFF means that the link was
still connected but only the bridge was disabled. If the link was
untouched, then interrupts shouldn't fire.
Even in the case of the DP compliance equipment, it should be raising these
interrupts during the start of the test which is usually accompanied with
either a HPD pulse or a IRQ HPD but after the bridge is disabled it should
be fine to handle these anyway. In the absence of a better reason to keep
these checks, drop these and if any other issues do arise, it should be
handled in a different way.
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
---
Note: Taken from https://patchwork.freedesktop.org/series/142010/
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index eabd6e6981fb..dd3fdeaacc91 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -495,9 +495,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 data)
drm_dbg_dp(dp->drm_dev, "Before, type=%d hpd_state=%d\n",
dp->msm_dp_display.connector_type, state);
- if (state == ST_DISPLAY_OFF)
- return 0;
-
if (state == ST_MAINLINK_READY || state == ST_CONNECTED)
return 0;
--
2.50.1
next prev parent reply other threads:[~2025-08-09 0:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 0:35 [PATCH v2 00/12] drm/msm/dp: Drop the HPD state machine Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 01/12] drm/msm/dp: fix HPD state status bit shift value Jessica Zhang
2025-08-09 0:38 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 02/12] drm/msm/dp: Fix the ISR_* enum values Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 03/12] drm/msm/dp: Read DPCD and sink count in bridge detect() Jessica Zhang
2025-08-09 0:44 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 04/12] drm/msm/dp: Move link training to atomic_enable() Jessica Zhang
2025-08-09 0:45 ` Dmitry Baryshkov
2025-08-09 0:53 ` Jessica Zhang
2025-08-09 0:51 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 05/12] drm/msm/dp: Drop EV_USER_NOTIFICATION Jessica Zhang
2025-08-09 2:14 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 06/12] drm/msm/dp: Use drm_bridge_hpd_notify() Jessica Zhang
2025-08-09 6:46 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 07/12] drm/msm/dp: Handle internal HPD IRQ in hpd_notify() Jessica Zhang
2025-08-09 7:05 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 08/12] drm/msm/dp: Drop event waitqueue Jessica Zhang
2025-08-09 7:08 ` Dmitry Baryshkov
2025-08-09 0:35 ` Jessica Zhang [this message]
2025-08-09 7:10 ` [PATCH v2 09/12] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug handler Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 10/12] drm/msm/dp: Return early from atomic_enable() if cable is not connected Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 11/12] drm/msm/dp: drop the entire HPD state machine Jessica Zhang
2025-08-09 7:26 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 12/12] drm/msm/dp: Add sink_count and link_ready to debug logs Jessica Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808-hpd-refactor-v2-9-7f4e1e741aa3@oss.qualcomm.com \
--to=jessica.zhang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_yongmou@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).