[PATCH v2] spi: spi-qpic-snand: avoid double assignment in qcom_spi_probe()

[PATCH v2] spi: spi-qpic-snand: avoid double assignment in qcom_spi_probe()

[Gabor Juhos]

The snandc->dev pointer is being assigned twice in the qcom_spi_probe()
function. Remove the second assignment as that uses the same pointer
value than the first one.

No functional changes.

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
Changes in v2:
  - fix a typo in commit description.
  - Link to v1: https://lore.kernel.org/r/20250804-qpic-snand-double-assign-fix-v1-1-9f4970107859@gmail.com
---
 drivers/spi/spi-qpic-snand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
index 0cfa0d960fd3c245c2bbf4f5e02d0fc0b13e7696..f6acf095fe196c3f778ba1c16157fc4bf273b66d 100644
--- a/drivers/spi/spi-qpic-snand.c
+++ b/drivers/spi/spi-qpic-snand.c
@@ -1541,7 +1541,6 @@ static int qcom_spi_probe(struct platform_device *pdev)
 	}
 
 	snandc->props = dev_data;
-	snandc->dev = &pdev->dev;
 
 	snandc->core_clk = devm_clk_get(dev, "core");
 	if (IS_ERR(snandc->core_clk))

---
base-commit: ffcfd071eec7973e58c4ffff7da4cb0e9ca7b667
change-id: 20250801-qpic-snand-double-assign-fix-cf4d78b9904a

Best regards,
-- 
Gabor Juhos <j4g8y7@gmail.com>

Re: [PATCH v2] spi: spi-qpic-snand: avoid double assignment in qcom_spi_probe()

[Mark Brown]

On Fri, 08 Aug 2025 15:15:32 +0200, Gabor Juhos wrote:
> The snandc->dev pointer is being assigned twice in the qcom_spi_probe()
> function. Remove the second assignment as that uses the same pointer
> value than the first one.
> 
> No functional changes.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-qpic-snand: avoid double assignment in qcom_spi_probe()
      commit: a1d0b0ae65ae3f32597edfbb547f16c75601cd87

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark