linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX
@ 2025-08-08  9:57 Yemike Abhilash Chandra
  2025-08-08  9:57 ` [PATCH V2 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:57 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra

The driver patch that adds support for error detection on the
Cadence CSI2RX by enabling its interrupt lines was recently
picked up [0].

Accordingly, this patch adds the required interrupts property
to the Cadence CSI2RX device tree nodes.

Changelog:
Changes in v2:
- Correct minor commit message mistake (patch 1/7)
- Collect R/B tags from Udit and Jared

Link for V1: https://lore.kernel.org/all/20250714092708.3944641-1-y-abhilashchandra@ti.com/

Test logs:
(To validate the complete functionality, CRC errors were
intentionally generated by modifying the sensor overlay)

AM68: https://gist.github.com/Yemike-Abhilash-Chandra/123fed82e798a76944ec23f8e46d1114
AM69: https://gist.github.com/Yemike-Abhilash-Chandra/1820e39888cb50e250a83e2d059365f6
J721E: https://gist.github.com/Yemike-Abhilash-Chandra/63f993a995fd6a12cb113454952c063f
J722S: https://gist.github.com/Yemike-Abhilash-Chandra/2144fc8ab2f7bcdb3ef868e85424467d
J721S2: https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
J784S4: https://gist.github.com/Yemike-Abhilash-Chandra/0c594683772f11c70bccb508757e9799

Driver and Binding patch series: https://lore.kernel.org/all/20250416121938.346435-1-y-abhilashchandra@ti.com/

[0]: https://lore.kernel.org/all/aG9tuMFOnvwXkcE-@valkosipuli.retiisi.eu/

Yemike Abhilash Chandra (7):
  arm64: dts: ti: k3-j721s2-main: Add interrupts property
  arm64: dts: ti: k3-j721e-main: Add interrupts property
  arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
  arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
  arm64: dts: ti: k3-j722s-main: Add interrupts property
  arm64: dts: ti: k3-am62-main: Add interrupts property
  arm64: dts: ti: k3-am62a-main: Add interrupts property

 arch/arm64/boot/dts/ti/k3-am62-main.dtsi                 | 3 +++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi                | 3 +++
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi   | 3 +++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 6 ++++++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 6 ++++++
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi                | 9 +++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
 7 files changed, 39 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH V2 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
@ 2025-08-08  9:57 ` Yemike Abhilash Chandra
  2025-08-08  9:57 ` [PATCH V2 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:57 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J721S2 TRM [0].

Interrupt Line      | Source Interrupt
--------------------|-----------------------------
GIC500SS_SPI_IN_185 | CSI_RX_IF0_CSI_ERR_IRQ_OUT_0
GIC500SS_SPI_IN_184 | CSI_RX_IF0_CSI_IRQ_OUT_0
GIC500SS_SPI_IN_189 | CSI_RX_IF1_CSI_ERR_IRQ_OUT_0
GIC500SS_SPI_IN_188 | CSI_RX_IF1_CSI_IRQ_OUT_0

[0]: https://www.ti.com/lit/zip/spruj28

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 62f45377a2c9..6f32a2b0c40c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04504000 0x00 0x1000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 3>,
 				<&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04514000 0x00 0x1000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 3>,
 				<&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 2/7] arm64: dts: ti: k3-j721e-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
  2025-08-08  9:57 ` [PATCH V2 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
@ 2025-08-08  9:57 ` Yemike Abhilash Chandra
  2025-08-08  9:58 ` [PATCH V2 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:57 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CSI2RX. Interrupt IDs are taken from the
J721E TRM [0].

Interrupt Line    | Source Interrupt
------------------|-------------------------
GIC500_SPI_IN_185 | CSI_RX_IF0_CSI_ERR_IRQ_0
GIC500_SPI_IN_184 | CSI_RX_IF0_CSI_IRQ_0
GIC500_SPI_IN_189 | CSI_RX_IF1_CSI_ERR_IRQ_0
GIC500_SPI_IN_188 | CSI_RX_IF1_CSI_IRQ_0

[0]: http://www.ti.com/lit/pdf/spruil1

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5bd0d36bf33e..ab3666ff4297 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -608,6 +608,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x0 0x4504000 0x0 0x1000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 26 2>, <&k3_clks 26 0>, <&k3_clks 26 2>,
 				<&k3_clks 26 2>, <&k3_clks 26 3>, <&k3_clks 26 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -661,6 +664,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x0 0x4514000 0x0 0x1000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 27 2>, <&k3_clks 27 0>, <&k3_clks 27 2>,
 				 <&k3_clks 27 2>, <&k3_clks 27 3>, <&k3_clks 27 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
  2025-08-08  9:57 ` [PATCH V2 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
  2025-08-08  9:57 ` [PATCH V2 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
@ 2025-08-08  9:58 ` Yemike Abhilash Chandra
  2025-08-08  9:58 ` [PATCH V2 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:58 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CSI2RX. Interrupt IDs are taken from the
J784S4 TRM [0].

Interrupt Line      | Source Interrupt
--------------------|-------------------------
GIC500SS_SPI_IN_185 | CSI_RX_IF0_CSI_ERR_IRQ_0
GIC500SS_SPI_IN_184 | CSI_RX_IF0_CSI_IRQ_0
GIC500SS_SPI_IN_189 | CSI_RX_IF1_CSI_ERR_IRQ_0
GIC500SS_SPI_IN_188 | CSI_RX_IF1_CSI_IRQ_0
GIC500SS_SPI_IN_193 | CSI_RX_IF2_CSI_ERR_IRQ_0
GIC500SS_SPI_IN_192 | CSI_RX_IF2_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/spruj52

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
index 7c5b0c69897d..2159ce0c942f 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
@@ -819,6 +819,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04504000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 72 2>, <&k3_clks 72 0>, <&k3_clks 72 2>,
 				<&k3_clks 72 2>, <&k3_clks 72 3>, <&k3_clks 72 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -872,6 +875,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04514000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 73 2>, <&k3_clks 73 0>, <&k3_clks 73 2>,
 				<&k3_clks 73 2>, <&k3_clks 73 3>, <&k3_clks 73 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -924,6 +930,9 @@ ti_csi2rx2: ticsi2rx@4520000 {
 		cdns_csi2rx2: csi-bridge@4524000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04524000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 74 2>, <&k3_clks 74 0>, <&k3_clks 74 2>,
 				<&k3_clks 74 2>, <&k3_clks 74 3>, <&k3_clks 74 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (2 preceding siblings ...)
  2025-08-08  9:58 ` [PATCH V2 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
@ 2025-08-08  9:58 ` Yemike Abhilash Chandra
  2025-08-08  9:58 ` [PATCH V2 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:58 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J722S TRM [0].

Interrupt Line     | Source Interrupt
-------------------|-------------------------
GICSS0_SPI_IN_175  | CSI_RX_IF0_CSI_ERR_IRQ_0
GICSS0_SPI_IN_173  | CSI_RX_IF0_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/sprujb3

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 2e5e25a8ca86..4427b12058a6 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -1045,6 +1045,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 5/7] arm64: dts: ti: k3-j722s-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (3 preceding siblings ...)
  2025-08-08  9:58 ` [PATCH V2 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
@ 2025-08-08  9:58 ` Yemike Abhilash Chandra
  2025-08-08  9:58 ` [PATCH V2 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:58 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J722S TRM [0].

Interrupt Line     | Source Interrupt
-------------------|-------------------------
GICSS0_SPI_IN_178  | CSI_RX_IF1_CSI_ERR_IRQ_0
GICSS0_SPI_IN_179  | CSI_RX_IF1_CSI_IRQ_0
GICSS0_SPI_IN_219  | CSI_RX_IF2_CSI_ERR_IRQ_0
GICSS0_SPI_IN_232  | CSI_RX_IF2_CSI_IRQ_0
GICSS0_SPI_IN_249  | CSI_RX_IF3_CSI_ERR_IRQ_0
GICSS0_SPI_IN_250  | CSI_RX_IF3_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/sprujb3

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
index 5cfa7bf36641..6a8e5ff3b1d5 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
@@ -168,6 +168,9 @@ ti_csi2rx1: ticsi2rx@30122000 {
 		cdns_csi2rx1: csi-bridge@30121000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30121000 0x00 0x1000>;
+			interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 247 0>, <&k3_clks 247 3>, <&k3_clks 247 0>,
 				 <&k3_clks 247 0>, <&k3_clks 247 4>, <&k3_clks 247 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -221,6 +224,9 @@ ti_csi2rx2: ticsi2rx@30142000 {
 		cdns_csi2rx2: csi-bridge@30141000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30141000 0x00 0x1000>;
+			interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 248 0>, <&k3_clks 248 3>, <&k3_clks 248 0>,
 				 <&k3_clks 248 0>, <&k3_clks 248 4>, <&k3_clks 248 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -274,6 +280,9 @@ ti_csi2rx3: ticsi2rx@30162000 {
 		cdns_csi2rx3: csi-bridge@30161000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30161000 0x00 0x1000>;
+			interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 249 0>, <&k3_clks 249 3>, <&k3_clks 249 0>,
 				 <&k3_clks 249 0>, <&k3_clks 249 4>, <&k3_clks 249 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 6/7] arm64: dts: ti: k3-am62-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (4 preceding siblings ...)
  2025-08-08  9:58 ` [PATCH V2 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
@ 2025-08-08  9:58 ` Yemike Abhilash Chandra
  2025-08-08  9:58 ` [PATCH V2 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
  2025-08-13 14:33 ` [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Nishanth Menon
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:58 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
AM62 TRM [0].

Interrupt Line | Source Interrupt
---------------|--------------------------
gicss0.spi.175 | csi_rx_if.0.csi_err_irq.0
gicss0.spi.173 | csi_rx_if.0.csi_irq.0

[0]: https://www.ti.com/lit/pdf/spruiv7

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 120ba8f9dd0e..029380dc1a35 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -1031,6 +1031,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH V2 7/7] arm64: dts: ti: k3-am62a-main: Add interrupts property
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (5 preceding siblings ...)
  2025-08-08  9:58 ` [PATCH V2 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
@ 2025-08-08  9:58 ` Yemike Abhilash Chandra
  2025-08-13 14:33 ` [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Nishanth Menon
  7 siblings, 0 replies; 9+ messages in thread
From: Yemike Abhilash Chandra @ 2025-08-08  9:58 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, linux-kernel, u-kumar1, y-abhilashchandra,
	Jared McArthur

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
AM62A TRM [0].

Interrupt Line             | Source Interrupt
---------------------------|----------------------------------
GICSS0_COMMON_0_SPI_IN_175 | CSI_RX_IF0_COMMON_0_CSI_ERR_IRQ_0
GICSS0_COMMON_0_SPI_IN_173 | CSI_RX_IF0_COMMON_0_CSI_IRQ_0

[0]: https://www.ti.com/lit/pdf/spruj16

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
Reviewed-by: Jared McArthur <j-mcarthur@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index 44e7e459f176..9cad79d7bbc1 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -1054,6 +1054,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX
  2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (6 preceding siblings ...)
  2025-08-08  9:58 ` [PATCH V2 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
@ 2025-08-13 14:33 ` Nishanth Menon
  7 siblings, 0 replies; 9+ messages in thread
From: Nishanth Menon @ 2025-08-13 14:33 UTC (permalink / raw)
  To: vigneshr, Yemike Abhilash Chandra
  Cc: Nishanth Menon, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
	linux-arm-kernel, devicetree, linux-kernel, u-kumar1

Hi Yemike Abhilash Chandra,

On Fri, 08 Aug 2025 15:27:57 +0530, Yemike Abhilash Chandra wrote:
> The driver patch that adds support for error detection on the
> Cadence CSI2RX by enabling its interrupt lines was recently
> picked up [0].
> 
> Accordingly, this patch adds the required interrupts property
> to the Cadence CSI2RX device tree nodes.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].

I did minor edits for the $subject to indicate it is CSI2.

Thank you!

[1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
      commit: 94801d4bf1ed9277462ebe1afaf8323664fd6a85
[2/7] arm64: dts: ti: k3-j721e-main: Add interrupts property
      commit: 33b34bfa4f22216845f5fd738d320e78d75cf1ff
[3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
      commit: 84ba1f67c6169e4533aa109888accbbccef25705
[4/7] arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
      commit: 347866a21ff447e868305426c294395b2cee68a7
[5/7] arm64: dts: ti: k3-j722s-main: Add interrupts property
      commit: 772cc597174486b85585ed02a74cc332ba25de01
[6/7] arm64: dts: ti: k3-am62-main: Add interrupts property
      commit: 96ba5ce55ec192ca28446d4045dfd501270769b3
[7/7] arm64: dts: ti: k3-am62a-main: Add interrupts property
      commit: 9307cad31efcfe3446847ee34effaaa5c4930fa8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-08-13 14:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-08  9:57 [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
2025-08-08  9:57 ` [PATCH V2 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
2025-08-08  9:57 ` [PATCH V2 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
2025-08-08  9:58 ` [PATCH V2 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
2025-08-08  9:58 ` [PATCH V2 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
2025-08-08  9:58 ` [PATCH V2 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
2025-08-08  9:58 ` [PATCH V2 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
2025-08-08  9:58 ` [PATCH V2 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
2025-08-13 14:33 ` [PATCH V2 0/7] Add Interrupts property for CDNS CSI2RX Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).