From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D38421CA1F for ; Mon, 11 Aug 2025 13:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754919390; cv=none; b=cL4qhPQMWZgkiBisFcNZBAQEesk/kEFfW8G9FKNbSG+dmLs4sCpnXpJUuKhUFHtifIPFHFR5yxvTBToK+aJSm7q1rKUVzv4tXZExHK0nHGi2DnPuZ+MXIqgkBov3NCYA+tXZCXHjH0S0EPwV3iij2CgSqvZ/+iCMz5x7XNnjMG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754919390; c=relaxed/simple; bh=Cvm3UxwZaIvytNrW2R0gZcHjx1lcF6maKDX+XWI55dE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OqMWAgXykN7RgLPWC2MYzYglsUv51p/VXzwNdxLFQ418D8m819RVB7Jy7QxL9/WRU/FLbnAc0Y15lOniYFhqh2cByIJYu6zaeSSIT8TxTnYHfN+Sc6EZpqlKsKNdNSpFWJnPn9Kgl9vUmuNBD0lENHONOiPYf9vvrdnZ+uT75TA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=06MRoUc3; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="06MRoUc3" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-458b49c98a7so27534415e9.1 for ; Mon, 11 Aug 2025 06:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754919387; x=1755524187; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rPC9QjkdXxMejFY4x5ok5uLAPYyJClZcqMLBbaZ87b0=; b=06MRoUc3RQriqaf5H6kL/Y6jSC33ZYGZp00YIvwqCD3ZGa21dvuigyDEDkUCnUl14O 5gyUvRwHgXOoykQjzVoVk8sCJlqzaUSPBer1Mu2EXsSrrE323Lj+jIkNGoJ9WAQuAi86 m9Z15/nOTfftBhV1nW7i1Xk5IQF+TaBYLdwwku88NiHTe1NECedG9raEg+jrqu6PCo8V 9DpCy8s3CHKdwO71Wtj9UIxYdZS6pZLbGuBr1oQGscfeLMngmgllIN5qubZF4bztp+T0 GHJ2bScHYOClmisekLM5Vx18V4rUxQX5JUIeckpS8YXITcfZ3pijrRnE9j7Ysnfai8F5 x8AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754919387; x=1755524187; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rPC9QjkdXxMejFY4x5ok5uLAPYyJClZcqMLBbaZ87b0=; b=BBS4ctYZB8ZHGOWt4+ETgrFNLxPwv+mzruMIuBs4V03SZySC2avjKUKBJcGEyFzAoT WXpXqvjdxaj1GGl+YSu1gwteIO4PH7q5EcrYsAOdyUm6/j7VB+Y6Ly0iNxRX6fHijHyu EFhykzgGySRTuB34+MVIr+XqF2H4jmXK7lKH1mbeptYVAOmw7eRHZxS6XvY149V7OLrS uYckfwtXDzRrln7nKAjCavp8vmEHCOr2bDCBZIs/7jnVpyCP+uWbV6gDcXBVcRYfRyaI ZkwmbfmQs/qKGG/kVwVz+cHsnPvgJvBpQTA8XmbC96oeKCFlwXKTQ2bIE6HwXlH87hvb bFWw== X-Forwarded-Encrypted: i=1; AJvYcCXaX1Kqa0/02U+IgnXUaW+MdZKRVktZiGr/pmbkTG8VaPTkfgiGq4LQXMNSDL7rOWxVjeveZQJVV5SKI64=@vger.kernel.org X-Gm-Message-State: AOJu0Yypkr0viyOcLdjSeAI2M7B1foHjX6eyfkBFDDZGWZbS88GQBDDX kgul0+Gs/ROvNVC9NGlcOLw3STcfb1BLnXpeOt77jfdeCP+ZbesKr78GWA3C83EoS9c= X-Gm-Gg: ASbGncvvBxm0UnPesMjDJl8oe4vIbFI22MRrI77qjBL2JPai6uTXjiphgfHjywbYkov MNs2iFKMXgmJfDOGoZ+19qt4/mZYe50DiLjkdsOKEoUtNXdvX6WvqkT8bxG2mK+W5TvnFq5ZqnG rfB8wSqSipYNSO0Wq37MSQDeXV94YHRjUxhW9LmoUGTZMzSBEY+20ZE8Jyoj5ssHKf4v3FOrhPT v0ZOyP6GTJedwDk9UbQipV1pqEUp5b9A1ux4ieFi8FMiWrCPjZ3ZNqom3/HbmewBiAYGifvX2Kx ewZzPznsNuaXFx9W1dQqFsmMKx971IoQjnyYn1J+OBCr0jiM2QZcoSN9hlY8rqJeQ/pv6PWpDv2 uV17Q1SUS5JHTQ6lxZg== X-Google-Smtp-Source: AGHT+IGO8tGE6CmpRp8d7Dv8oPbrNyboejFtiyDhBBX2/eeF8sA7SMGla8jnfhdxvPUYVbbA5Sca3Q== X-Received: by 2002:a05:600c:1c18:b0:459:443e:b180 with SMTP id 5b1f17b1804b1-459f4f3e153mr120440835e9.8.1754919386578; Mon, 11 Aug 2025 06:36:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6841:8926:4410:c880]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e587d378sm253045105e9.23.2025.08.11.06.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 06:36:25 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 11 Aug 2025 15:36:16 +0200 Subject: [PATCH 1/2] mfd: vexpress-sysreg: check the return value of devm_gpiochip_add_data() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250811-gpio-mmio-mfd-conv-v1-1-68c5c958cf80@linaro.org> References: <20250811-gpio-mmio-mfd-conv-v1-0-68c5c958cf80@linaro.org> In-Reply-To: <20250811-gpio-mmio-mfd-conv-v1-0-68c5c958cf80@linaro.org> To: Lee Jones , Linus Walleij , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Pawel Moll Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1563; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=npVo4x9jWTs/C5oZ+18P177rzmdj25fbWuss0PN0sgc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomfHY3wi3JBmgBHiBE2qvpEWlJzPK24kglGeUX xNZz9M+CuKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJnx2AAKCRARpy6gFHHX ck4YD/9c0CqewiZHWF6/YFXoIqPUFIkHmddOhFieqmRdmF/yNc5waGN9erdg30PR/wywPs+kh2M PjWfHrs1tOet67Q/bfY9F2IqNibNOE9bxDVK+qs+uQZHj4z5f69AdGlLuAhNym++2ff4zHg0lTV ZkaSOLnVLDJVP2sLKAyCYxrViDNfbEhZnY2Uu8i5rbtHewxH+ZFDmxHX1ikemAk5Hi9e2HuUIMo rnaN5L9J2P4w1GwQTIDn++ml9Ew/BjhUZm+cQt9A91n22y/lWvdzHhnG4GqVTMBiuh8Yx1tRCZW dNQK08q2kM+JphEbuSkwEOwYa+CNIeGQ38q1gQpgTwDEQp9Kx0xs796lFX+xMr1sYretdbFiXaL 4HksGf74zJAwsI5xRnkqLdb0QpAs8D78JNoaAtnMFhbMvwwEd/mWUlMhrmgx7YfY31JytU5teTb tW/3BdG+yz7M2Oww16f4xylTWevar1CUxrXfpDSYmmQ+fbO9/YcN5uHt9m3RXVnqsvbOxG0ugAM h/UUQy1fha5KHs4hANSsR+ezcPEd1uT0EIxDcHh6dGfcLCO9FkA3yktahT0OvJ7c8DNl6kYxD2M v/ZwWMfYppyp30Po+U4Tu1OfAuaQRnlcowPcUL9pisVN03koxnAzPyXJcyq/lN1bkWhIuTBquAz WYRMxHmxYqDtGQg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Commit 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells") removed the return value check from the call to gpiochip_add_data() (or rather gpiochip_add() back then and later converted to devres) with no explanation. This function however can still fail, so check the return value and bail-out if it does. Cc: stable@vger.kernel.org Fixes: 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells") Signed-off-by: Bartosz Golaszewski --- drivers/mfd/vexpress-sysreg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c index fc2daffc4352cca763cefbf6e17bdd5242290198..77245c1e5d7df497fda2f6dd8cfb08b5fbcee719 100644 --- a/drivers/mfd/vexpress-sysreg.c +++ b/drivers/mfd/vexpress-sysreg.c @@ -99,6 +99,7 @@ static int vexpress_sysreg_probe(struct platform_device *pdev) struct resource *mem; void __iomem *base; struct gpio_chip *mmc_gpio_chip; + int ret; mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!mem) @@ -119,7 +120,10 @@ static int vexpress_sysreg_probe(struct platform_device *pdev) bgpio_init(mmc_gpio_chip, &pdev->dev, 0x4, base + SYS_MCI, NULL, NULL, NULL, NULL, 0); mmc_gpio_chip->ngpio = 2; - devm_gpiochip_add_data(&pdev->dev, mmc_gpio_chip, NULL); + + ret = devm_gpiochip_add_data(&pdev->dev, mmc_gpio_chip, NULL); + if (ret) + return ret; return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, vexpress_sysreg_cells, -- 2.48.1