From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Nam Cao <namcao@linutronix.de>
Cc: "Nirmal Patel" <nirmal.patel@linux.intel.com>,
"Jonathan Derrick" <jonathan.derrick@linux.dev>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Armando Budianto" <sprite@gnuweeb.org>,
"Alviro Iskandar Setiawan" <alviro.iskandar@gnuweeb.org>
Subject: Re: [PATCH] PCI: vmd: Remove MSI-X check on child devices
Date: Mon, 11 Aug 2025 12:53:43 +0700 [thread overview]
Message-ID: <20250811055343.GA1405254-ammarfaizi2@gnuweeb.org> (raw)
In-Reply-To: <20250811053935.4049211-1-namcao@linutronix.de>
On Mon, Aug 11, 2025 at 07:39:35AM +0200, Nam Cao wrote:
> Commit d7d8ab87e3e7 ("PCI: vmd: Switch to msi_create_parent_irq_domain()")
> added a WARN_ON sanity check that child devices support MSI-X, because VMD
> document says [1]:
>
> "Intel VMD only supports MSIx Interrupts from child devices and
> therefore the BIOS must enable PCIe Hot Plug and MSIx interrups [sic]."
>
> However, on Ammar's machine, a PCIe port below VMD does not support MSI-X,
> triggering this WARN_ON.
>
> This inconsistency between the document and reality should be investigated
> further. For now, remove the MSI-X check.
Posting the processor model in question here for Intel VMD team. It may
help the investigation. The processor model I use is i7-1165G7.
Let me know if you guys need more information from me.
--
Ammar Faizi
next prev parent reply other threads:[~2025-08-11 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 5:39 [PATCH] PCI: vmd: Remove MSI-X check on child devices Nam Cao
2025-08-11 5:53 ` Ammar Faizi [this message]
2025-08-11 22:46 ` Bjorn Helgaas
2025-08-12 6:27 ` Nam Cao
2025-08-12 14:49 ` Keith Busch
2025-08-12 16:30 ` Bjorn Helgaas
2025-08-12 18:22 ` Nam Cao
2025-08-12 19:00 ` Bjorn Helgaas
2025-08-12 19:32 ` Nam Cao
2025-08-12 19:41 ` Keith Busch
2025-08-12 19:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811055343.GA1405254-ammarfaizi2@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@linux.dev \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=namcao@linutronix.de \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
--cc=sprite@gnuweeb.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox