From: Xiaolei Wang <xiaolei.wang@windriver.com>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
jani.nikula@intel.com, ville.syrjala@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state
Date: Mon, 11 Aug 2025 14:34:03 +0800 [thread overview]
Message-ID: <20250811063403.98739-1-xiaolei.wang@windriver.com> (raw)
Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers")
added the atomic state path, so adding the drm connector
atomic_[duplicate/destroy]_state is also necessary.
WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0
Call trace:
drm_connector_init_only+0x934/0xee0 (P)
drmm_connector_init+0xe0/0x1b0
drm_client_modeset_test_init+0x290/0x534
kunit_try_run_case+0x110/0x3b4
kunit_generic_run_threadfn_adapter+0x80/0xec
kthread+0x3b8/0x6c0
ret_from_fork+0x10/0x20
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_client_modeset_test.c b/drivers/gpu/drm/tests/drm_client_modeset_test.c
index 3f44fe5e92e4..e702a27c2368 100644
--- a/drivers/gpu/drm/tests/drm_client_modeset_test.c
+++ b/drivers/gpu/drm/tests/drm_client_modeset_test.c
@@ -12,6 +12,7 @@
#include <drm/drm_modes.h>
#include <drm/drm_modeset_helper_vtables.h>
#include <drm/drm_probe_helper.h>
+#include <drm/drm_atomic_state_helper.h>
struct drm_client_modeset_test_priv {
struct drm_device *drm;
@@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs drm_client_modeset_connector_help
};
static const struct drm_connector_funcs drm_client_modeset_connector_funcs = {
+ .reset = drm_atomic_helper_connector_reset,
+ .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+ .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};
static int drm_client_modeset_test_init(struct kunit *test)
--
2.43.0
next reply other threads:[~2025-08-11 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 6:34 Xiaolei Wang [this message]
2025-08-20 14:03 ` [PATCH] drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state Maxime Ripard
2025-08-21 11:21 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811063403.98739-1-xiaolei.wang@windriver.com \
--to=xiaolei.wang@windriver.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox