From: Vladimir Oltean <olteanv@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Schirm <andreas.schirm@siemens.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Lukas Stockmann <lukas.stockmann@siemens.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH/RFC net] net: dsa: lantiq_gswip: honor dsa_db passed to port_fdb_{add,del}
Date: Mon, 11 Aug 2025 18:32:42 +0300 [thread overview]
Message-ID: <20250811153242.znhebimdzc2erznt@skbuf> (raw)
In-Reply-To: <20250810210200.6n3xguqi5ukbybm2@skbuf>
Hi Daniel,
On Mon, Aug 11, 2025 at 12:02:00AM +0300, Vladimir Oltean wrote:
> I suggest tools/testing/selftests/net/forwarding/local_termination.sh
> once dsa_switch_supports_uc_filtering() returns true.
Since you're working with the lantiq_gswip driver which receives
relatively few patches...
I would like to submit this patch to remove the legacy behavior:
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 6b8a5101b0e7..7e11f198ff2b 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -886,8 +886,6 @@ static int gswip_setup(struct dsa_switch *ds)
ds->mtu_enforcement_ingress = true;
- ds->configure_vlan_while_not_filtering = false;
-
return 0;
}
however I'm sure that the driver will break, so I have more, in an
attempt to avoid that :)
Would you please look at the patches I've prepared on this branch and
reviewing with extra info you might have / giving them a test, one by one?
I was only able to compile-test them. I also lack proper documentation
(which I'm sure you lack too), I only saw the "developer resources" from
Martin Blumenstingl's Github (which lack actual PCE register descriptions)
https://github.com/xdarklight/ltq-upstream-status
and the Maxlinear PRPLOS code at
https://github.com/maxlinear/linux/tree/UPDK_9.1.90/drivers/net/datapath/gswip/switchcore/src
(which I think is what you were also referencing)
The branch over net-next is here:
https://github.com/vladimiroltean/linux/commits/lantiq-gswip/
Thanks!
next prev parent reply other threads:[~2025-08-11 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 22:35 [PATCH/RFC net] net: dsa: lantiq_gswip: honor dsa_db passed to port_fdb_{add,del} Daniel Golle
2025-08-10 13:06 ` Vladimir Oltean
2025-08-10 14:48 ` Daniel Golle
2025-08-10 16:32 ` Vladimir Oltean
2025-08-10 16:54 ` Daniel Golle
2025-08-10 21:02 ` Vladimir Oltean
2025-08-11 15:32 ` Vladimir Oltean [this message]
2025-08-12 1:23 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811153242.znhebimdzc2erznt@skbuf \
--to=olteanv@gmail.com \
--cc=alexander.sverdlin@siemens.com \
--cc=andreas.schirm@siemens.com \
--cc=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.stockmann@siemens.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).