From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andreas Hindborg <a.hindborg@kernel.org>,
Daniel Almeida <daniel.almeida@collabora.com>
Subject: [PATCH v4 07/15] rust: block: remove `RawWriter`
Date: Tue, 12 Aug 2025 10:44:25 +0200 [thread overview]
Message-ID: <20250812-rnull-up-v6-16-v4-7-ed801dd3ba5c@kernel.org> (raw)
In-Reply-To: <20250812-rnull-up-v6-16-v4-0-ed801dd3ba5c@kernel.org>
`RawWriter` is now dead code, so remove it.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
---
rust/kernel/block/mq.rs | 1 -
rust/kernel/block/mq/raw_writer.rs | 56 --------------------------------------
2 files changed, 57 deletions(-)
diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs
index 831445d37181..98fa0d6bc8f7 100644
--- a/rust/kernel/block/mq.rs
+++ b/rust/kernel/block/mq.rs
@@ -89,7 +89,6 @@
pub mod gen_disk;
mod operations;
-mod raw_writer;
mod request;
mod tag_set;
diff --git a/rust/kernel/block/mq/raw_writer.rs b/rust/kernel/block/mq/raw_writer.rs
deleted file mode 100644
index 0aef55703e71..000000000000
--- a/rust/kernel/block/mq/raw_writer.rs
+++ /dev/null
@@ -1,56 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-
-use core::fmt::{self, Write};
-
-use crate::error::Result;
-use crate::prelude::EINVAL;
-
-/// A mutable reference to a byte buffer where a string can be written into.
-///
-/// # Invariants
-///
-/// `buffer` is always null terminated.
-pub(crate) struct RawWriter<'a> {
- buffer: &'a mut [u8],
- pos: usize,
-}
-
-impl<'a> RawWriter<'a> {
- /// Create a new `RawWriter` instance.
- fn new(buffer: &'a mut [u8]) -> Result<RawWriter<'a>> {
- *(buffer.last_mut().ok_or(EINVAL)?) = 0;
-
- // INVARIANT: We null terminated the buffer above.
- Ok(Self { buffer, pos: 0 })
- }
-
- #[expect(dead_code)]
- pub(crate) fn from_array<const N: usize>(
- a: &'a mut [crate::ffi::c_char; N],
- ) -> Result<RawWriter<'a>> {
- Self::new(
- // SAFETY: the buffer of `a` is valid for read and write as `u8` for
- // at least `N` bytes.
- unsafe { core::slice::from_raw_parts_mut(a.as_mut_ptr().cast::<u8>(), N) },
- )
- }
-}
-
-impl Write for RawWriter<'_> {
- fn write_str(&mut self, s: &str) -> fmt::Result {
- let bytes = s.as_bytes();
- let len = bytes.len();
-
- // We do not want to overwrite our null terminator
- if self.pos + len > self.buffer.len() - 1 {
- return Err(fmt::Error);
- }
-
- // INVARIANT: We are not overwriting the last byte
- self.buffer[self.pos..self.pos + len].copy_from_slice(bytes);
-
- self.pos += len;
-
- Ok(())
- }
-}
--
2.47.2
next prev parent reply other threads:[~2025-08-12 8:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:44 [PATCH v4 00/15] rnull: add configfs, remote completion to rnull Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 01/15] rust: str: normalize imports in `str.rs` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 02/15] rust: str: allow `str::Formatter` to format into `&mut [u8]` Andreas Hindborg
2025-08-13 7:18 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 03/15] rust: str: expose `str::{Formatter, RawFormatter}` publicly Andreas Hindborg
2025-08-13 7:18 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 04/15] rust: str: introduce `NullTerminatedFormatter` Andreas Hindborg
2025-08-13 7:21 ` Alice Ryhl
2025-08-13 12:34 ` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 05/15] rust: block: normalize imports for `gen_disk.rs` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 06/15] rust: block: use `NullTerminatedFormatter` Andreas Hindborg
2025-08-13 7:22 ` Alice Ryhl
2025-08-12 8:44 ` Andreas Hindborg [this message]
2025-08-12 8:44 ` [PATCH v4 08/15] rust: block: remove trait bound from `mq::Request` definition Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 09/15] rust: block: add block related constants Andreas Hindborg
2025-08-13 7:22 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 10/15] rnull: move driver to separate directory Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 11/15] rnull: enable configuration via `configfs` Andreas Hindborg
2025-08-13 7:27 ` Alice Ryhl
2025-08-13 12:47 ` Andreas Hindborg
2025-08-13 13:54 ` Alice Ryhl
2025-08-13 17:36 ` Andreas Hindborg
2025-08-13 18:05 ` Alice Ryhl
2025-08-14 7:40 ` Andreas Hindborg
2025-08-14 8:58 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 12/15] rust: block: add `GenDisk` private data support Andreas Hindborg
2025-08-13 7:30 ` Alice Ryhl
2025-08-13 12:56 ` Andreas Hindborg
2025-08-13 13:50 ` Alice Ryhl
2025-08-12 8:44 ` [PATCH v4 13/15] rust: block: mq: fix spelling in a safety comment Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 14/15] rust: block: add remote completion to `Request` Andreas Hindborg
2025-08-12 8:44 ` [PATCH v4 15/15] rnull: add soft-irq completion support Andreas Hindborg
2025-08-13 7:32 ` Alice Ryhl
2025-08-14 18:28 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812-rnull-up-v6-16-v4-7-ed801dd3ba5c@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).