From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: storage: realtek_cr: Simplify rts51x_bulk_transport()
Date: Tue, 12 Aug 2025 17:00:10 +0200 [thread overview]
Message-ID: <2025081249-guru-uptight-98bf@gregkh> (raw)
In-Reply-To: <20250812144358.122154-1-thorsten.blum@linux.dev>
On Tue, Aug 12, 2025 at 04:43:58PM +0200, Thorsten Blum wrote:
> Change the function parameter 'buf_len' from 'int' to 'unsigned int' and
> only update the local variable 'residue' if needed.
But why?
> Update the rts51x_read_status() function signature accordingly.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/usb/storage/realtek_cr.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Have you tested this change? What caused this to be needed?
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-12 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 14:43 [PATCH] usb: storage: realtek_cr: Simplify rts51x_bulk_transport() Thorsten Blum
2025-08-12 15:00 ` Greg Kroah-Hartman [this message]
2025-08-12 15:35 ` Thorsten Blum
2025-08-12 20:06 ` Alan Stern
2025-08-12 21:28 ` Thorsten Blum
2025-08-13 1:38 ` [usb-storage] " Alan Stern
2025-08-13 10:17 ` [usb-storage] " Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081249-guru-uptight-98bf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=thorsten.blum@linux.dev \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).