From: Yusuf Alper Bilgin <y.alperbilgin@gmail.com>
To: krzk@kernel.org
Cc: Michael.Hennerich@analog.com, andy@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, jic23@kernel.org, krzk+dt@kernel.org,
lars@metafoo.de, liambeguin@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, nuno.sa@analog.com,
robh@kernel.org, y.alperbilgin@gmail.com
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: ltc2497: add docs for LTC2495
Date: Wed, 13 Aug 2025 10:44:44 +0200 [thread overview]
Message-ID: <20250813084444.1842413-1-y.alperbilgin@gmail.com> (raw)
In-Reply-To: <0ece8b0e-6c20-42ca-a3a6-4c35ee2be07b@kernel.org>
Hi Krzysztof,
Thank you for the review and guidance.
On Tue, Aug 12, 2025 at 07:04:00PM +0200, Krzysztof Kozlowski wrote:
> What are the differences, why it cannot be made compatible with 2497
> (fallback)?
The LTC2495 offers a more advanced feature set compared to the LTC2497,
including:
- Adjustable input gain
- A selectable 50Hz/60Hz lowpass filter to reject line frequency noise
- Selectable speed modes
- An internal temperature sensor
All of these features are configured via a second I2C command byte
(listed in Table 4 of:
https://www.analog.com/media/en/technical-documentation/data-sheets/2495fe.pdf),
which changes the driver's communication protocol compared to the
single-byte commands of the LTC2497.
This patch series begins to support reading the internal temperature
sensor by implementing driver logic for the two-byte I2C command format
and exposing the IIO temperature channel. Therefore, I added a new
binding. Without the support for the temperature sensor and this
different command structure, a simple fallback would be sufficient.
Let me know if you agree with the reasoning to add the binding. If so, I
will update the commit messages in v2 to include this justification and
ensure they follow the imperative mood convention.
Best regards,
Alper
next prev parent reply other threads:[~2025-08-13 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 17:04 [PATCH 0/3] Add LTC2495 support Yusuf Alper Bilgin
2025-08-12 17:04 ` [PATCH 1/3] dt-bindings: iio: adc: ltc2497: add docs for LTC2495 Yusuf Alper Bilgin
2025-08-12 18:00 ` Krzysztof Kozlowski
2025-08-13 8:44 ` Yusuf Alper Bilgin [this message]
2025-08-16 10:23 ` Jonathan Cameron
2025-08-18 16:26 ` Alper Bilgin
2025-08-17 7:11 ` Krzysztof Kozlowski
2025-08-12 17:04 ` [PATCH 2/3] iio: adc: ltc2497: add support " Yusuf Alper Bilgin
2025-08-13 10:18 ` Andy Shevchenko
2025-08-12 17:04 ` [PATCH 3/3] iio: adc: ltc2497: add temperature sensor support Yusuf Alper Bilgin
2025-08-13 10:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813084444.1842413-1-y.alperbilgin@gmail.com \
--to=y.alperbilgin@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).