[PATCH][next] drm/dp: remove redundant check on ret and return statement

[PATCH][next] drm/dp: remove redundant check on ret and return statement

[Colin Ian King]

There is a redundant check on return and a return statement after
a previous return statement from the call to drm_dp_dpcd_write_byte.
These statements are redundant and can be removed. Remove the
statements and the now unused variable ret.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index 1ecc3df7e316..ccae67abb8ff 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -3594,7 +3594,6 @@ EXPORT_SYMBOL(drm_dp_pcon_frl_configure_1);
 int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask,
 				u8 frl_type)
 {
-	int ret;
 	u8 buf = max_frl_mask;
 
 	if (frl_type == DP_PCON_FRL_LINK_TRAIN_EXTENDED)
@@ -3603,10 +3602,6 @@ int drm_dp_pcon_frl_configure_2(struct drm_dp_aux *aux, int max_frl_mask,
 		buf &= ~DP_PCON_FRL_LINK_TRAIN_EXTENDED;
 
 	return drm_dp_dpcd_write_byte(aux, DP_PCON_HDMI_LINK_CONFIG_2, buf);
-	if (ret < 0)
-		return ret;
-
-	return 0;
 }
 EXPORT_SYMBOL(drm_dp_pcon_frl_configure_2);
 
-- 
2.50.1

Re: [PATCH][next] drm/dp: remove redundant check on ret and return statement

[Dmitry Baryshkov]

On Wed, Aug 13, 2025 at 04:12:43PM +0100, Colin Ian King wrote:
> There is a redundant check on return and a return statement after
> a previous return statement from the call to drm_dp_dpcd_write_byte.
> These statements are redundant and can be removed. Remove the
> statements and the now unused variable ret.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 5 -----
>  1 file changed, 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry