Re: [PATCH] iomap: use largest_zero_folio() in iomap_dio_zero()

Pankaj Raghav (Samsung)
2025-08-14T21:19:03Z

On Thu, Aug 14, 2025 at 11:27:13AM -0700, Darrick J. Wong wrote:
> On Thu, Aug 14, 2025 at 04:21:37PM +0200, Pankaj Raghav (Samsung) wrote:
> > From: Pankaj Raghav <p.raghav@samsung.com>
> >
> > iomap_dio_zero() uses a custom allocated memory of zeroes for padding
> > zeroes. This was a temporary solution until there was a way to request a
> > zero folio that was greater than the PAGE_SIZE.
> >
> > Use largest_zero_folio() function instead of using the custom allocated
> > memory of zeroes. There is no guarantee from largest_zero_folio()
> > function that it will always return a PMD sized folio. Adapt the code so
> > that it can also work if largest_zero_folio() returns a ZERO_PAGE.
> >
> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>
> Seems fine to me, though I wonder if this oughn't go along with the
> rest of the largest_zero_folio changes?

I included them in one of the early versions but later removed as we had
to rework the implementation multiple times. I just wanted to reduce the
scope of the series and send out changes that uses the API separately :).

>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

Thanks!

--
Pankaj Raghav