Re: [PATCH] iomap: use largest_zero_folio() in iomap_dio_zero()

Andrew Morton
2025-08-19T03:14:04Z

On Mon, 18 Aug 2025 16:35:04 +0200 Pankaj Raghav <p.raghav@samsung.com> wrote:

> >>> Applied to the vfs-6.18.iomap branch of the vfs/vfs.git tree.
> >>> Patches in the vfs-6.18.iomap branch should appear in linux-next soon.
> >>
> >> Hmm, AFAIK largest_zero_folio just showed up in mm.git a few days ago.
> >> Wouldn't it be better to queue up this change there?
> >>
> >>
> >
> > Indeed, compiling vfs/vfs.all as of today fails with:
> >
> > fs/iomap/direct-io.c:281:36: error: implicit declaration of function
> > ‘largest_zero_folio’; did you mean ‘is_zero_folio’? [-Wimplicit-
> > function-declaration]
> >
> > Reverting "iomap: use largest_zero_folio() in iomap_dio_zero()" fixes
> > the compilation.
> >
>
> I also got some reports from Stephen in linux-next. As Christoph
> suggested, maybe we drop the patches from Christian's tree and queue it
> up via Andrew's tree

Thanks, I added it to mm.git.