From: Oleg Nesterov <oleg@redhat.com>
To: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: David Laight <david.laight.linux@gmail.com>,
Li RongQing <lirongqing@baidu.com>, Yu Kuai <yukuai3@huawei.com>,
Khazhismel Kumykov <khazhy@chromium.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: [PATCH v3 2/2] blk-throttle: kill the no longer needed overflow check in calculate_bytes_allowed()
Date: Fri, 15 Aug 2025 18:41:02 +0200 [thread overview]
Message-ID: <20250815164102.GA13658@redhat.com> (raw)
In-Reply-To: <20250815164009.GA11676@redhat.com>
Now that mul_u64_u64_div_u64() can't crash there is no need to check for
possible overflow in calculate_bytes_allowed().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
block/blk-throttle.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 397b6a410f9e..66339e22cc85 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -601,12 +601,6 @@ static unsigned int calculate_io_allowed(u32 iops_limit,
static u64 calculate_bytes_allowed(u64 bps_limit, unsigned long jiffy_elapsed)
{
- /*
- * Can result be wider than 64 bits?
- * We check against 62, not 64, due to ilog2 truncation.
- */
- if (ilog2(bps_limit) + ilog2(jiffy_elapsed) - ilog2(HZ) > 62)
- return U64_MAX;
return mul_u64_u64_div_u64(bps_limit, (u64)jiffy_elapsed, (u64)HZ);
}
--
2.25.1.362.g51ebf55
next prev parent reply other threads:[~2025-08-15 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:40 [PATCH v3 0/2] x86/math64: handle #DE in mul_u64_u64_div_u64() Oleg Nesterov
2025-08-15 16:40 ` [PATCH v3 1/2] " Oleg Nesterov
2025-08-15 16:41 ` Oleg Nesterov [this message]
2025-08-17 12:50 ` [PATCH v3 2/2] blk-throttle: kill the no longer needed overflow check in calculate_bytes_allowed() David Laight
2025-08-17 17:06 ` H. Peter Anvin
2025-08-18 13:21 ` Oleg Nesterov
2025-08-17 13:07 ` [PATCH v3 0/2] x86/math64: handle #DE in mul_u64_u64_div_u64() David Laight
2025-08-18 12:39 ` Oleg Nesterov
2025-08-18 18:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815164102.GA13658@redhat.com \
--to=oleg@redhat.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=hpa@zytor.com \
--cc=khazhy@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox