* [PATCH] siox: bus-gpio: Remove the use of dev_err_probe()
@ 2025-08-19 12:17 Xichao Zhao
2025-08-24 21:29 ` Thorsten Scherer
0 siblings, 1 reply; 2+ messages in thread
From: Xichao Zhao @ 2025-08-19 12:17 UTC (permalink / raw)
To: t.scherer; +Cc: kernel, linux-kernel, Xichao Zhao
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just
return the value instead.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/siox/siox-bus-gpio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/siox/siox-bus-gpio.c b/drivers/siox/siox-bus-gpio.c
index d6f936464063..413d5f92311c 100644
--- a/drivers/siox/siox-bus-gpio.c
+++ b/drivers/siox/siox-bus-gpio.c
@@ -93,8 +93,7 @@ static int siox_gpio_probe(struct platform_device *pdev)
smaster = devm_siox_master_alloc(dev, sizeof(*ddata));
if (!smaster)
- return dev_err_probe(dev, -ENOMEM,
- "failed to allocate siox master\n");
+ return -ENOMEM;
platform_set_drvdata(pdev, smaster);
ddata = siox_master_get_devdata(smaster);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] siox: bus-gpio: Remove the use of dev_err_probe()
2025-08-19 12:17 [PATCH] siox: bus-gpio: Remove the use of dev_err_probe() Xichao Zhao
@ 2025-08-24 21:29 ` Thorsten Scherer
0 siblings, 0 replies; 2+ messages in thread
From: Thorsten Scherer @ 2025-08-24 21:29 UTC (permalink / raw)
To: Xichao Zhao, Greg Kroah-Hartman; +Cc: kernel, linux-kernel
Hello Xichao, Hello Greg,
On Tue, Aug 19, 2025 at 08:17:49PM +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
@gregkh: Could you please take this patch into your tree?
Xichao, thank you for your contribution and Greg, thank you for taking
care.
Best regards
Thorsten
> ---
> drivers/siox/siox-bus-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/siox/siox-bus-gpio.c b/drivers/siox/siox-bus-gpio.c
> index d6f936464063..413d5f92311c 100644
> --- a/drivers/siox/siox-bus-gpio.c
> +++ b/drivers/siox/siox-bus-gpio.c
> @@ -93,8 +93,7 @@ static int siox_gpio_probe(struct platform_device *pdev)
>
> smaster = devm_siox_master_alloc(dev, sizeof(*ddata));
> if (!smaster)
> - return dev_err_probe(dev, -ENOMEM,
> - "failed to allocate siox master\n");
> + return -ENOMEM;
>
> platform_set_drvdata(pdev, smaster);
> ddata = siox_master_get_devdata(smaster);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-24 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 12:17 [PATCH] siox: bus-gpio: Remove the use of dev_err_probe() Xichao Zhao
2025-08-24 21:29 ` Thorsten Scherer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).