The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] sysfs: attribute_group: enable const variants of is_visible()
Date: Tue, 19 Aug 2025 13:28:40 +0200	[thread overview]
Message-ID: <2025081957-promotion-shrivel-32cc@gregkh> (raw)
In-Reply-To: <20250811-sysfs-const-attr-prep-v3-4-0d973ff46afc@weissschuh.net>

On Mon, Aug 11, 2025 at 11:14:30AM +0200, Thomas Weißschuh wrote:
> When constifying instances of struct attribute, for consistency the
> corresponding .is_visible() callback should be adapted, too.
> Introduce a temporary transition mechanism until all callbacks are
> converted.

I count about 600+ users of is_visible() now, how is that going to be
converted?  It feels like a lot of churn/work, what's the plan here?

These changes seem a lot more intrusive than the bin_attr ones :(

thanks,

greg k-h

  reply	other threads:[~2025-08-19 11:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11  9:14 [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 1/7] sysfs: attribute_group: allow registration of const attribute Thomas Weißschuh
2025-08-19 11:22   ` Greg Kroah-Hartman
2025-08-19 13:59     ` Thomas Weißschuh
2025-08-19 14:10       ` Greg Kroah-Hartman
2025-08-19 14:15         ` Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 2/7] sysfs: transparently handle const pointers in ATTRIBUTE_GROUPS() Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 3/7] sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE() Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 4/7] sysfs: attribute_group: enable const variants of is_visible() Thomas Weißschuh
2025-08-19 11:28   ` Greg Kroah-Hartman [this message]
2025-08-19 14:07     ` Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 5/7] samples/kobject: add is_visible() callback to attribute group Thomas Weißschuh
2025-08-19 11:24   ` Greg Kroah-Hartman
2025-08-19 14:00     ` Thomas Weißschuh
2025-08-11  9:14 ` [PATCH v3 6/7] samples/kobject: constify 'struct foo_attribute' Thomas Weißschuh
2025-08-19 11:27   ` Greg Kroah-Hartman
2025-08-11  9:14 ` [PATCH v3 7/7] sysfs: simplify attribute definition macros Thomas Weißschuh
2025-08-12 14:36 ` [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025081957-promotion-shrivel-32cc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dakr@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox