The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chunsheng Luo <luochunsheng@ustc.edu>
To: miklos@szeredi.hu
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	luochunsheng@ustc.edu
Subject: Re: [PATCH] fuse: clarify extending writes handling
Date: Wed, 20 Aug 2025 10:11:43 +0800	[thread overview]
Message-ID: <20250820021143.1069-1-luochunsheng@ustc.edu> (raw)
In-Reply-To: <CAJfpegsz3fScMWh4BVuzax1ovVN5qEm1yr8g=XEU0DnsHbXCvQ@mail.gmail.com>

Tue, 19 Aug 2025 16:07:19 Miklos Szeredi wrote:

>>
>> Only flush extending writes (up to LLONG_MAX) for files with upcoming
>> write operations, and Fix confusing 'end' parameter usage.
>
> Patch looks correct, but it changes behavior on input file of
> copy_file_range(), which is not explained here.

Thank you for your review.

For the copy_file_range input file, since it only involves read operations,
I think it is not necessary to flush to LLONG_MAX. Therefore, for the input file, 
flushing to the end is sufficient.

If you think my understanding is correct, I can resend a revised version of
the patch to update the commit log and include a clear explanation regarding
the behavior changes in 'fuse_copy_file_range' and 'fuse_file_fallocate' operations.

Thanks
Chunsheng Luo

  reply	other threads:[~2025-08-20  2:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 13:29 [PATCH] fuse: clarify extending writes handling Chunsheng Luo
2025-08-19 14:07 ` Miklos Szeredi
2025-08-20  2:11   ` Chunsheng Luo [this message]
2025-08-20  5:20     ` Darrick J. Wong
2025-08-20  6:52       ` Miklos Szeredi
2025-08-20 16:27         ` Darrick J. Wong
2025-08-21  6:25           ` Chunsheng Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250820021143.1069-1-luochunsheng@ustc.edu \
    --to=luochunsheng@ustc.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox