From: Jakub Kicinski <kuba@kernel.org>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
leon@kernel.org, ecree.xilinx@gmail.com, dsahern@kernel.org,
ncardwell@google.com, kuniyu@google.com, shuah@kernel.org,
sdf@fomichev.me, aleksander.lobakin@intel.com,
florian.fainelli@broadcom.com, willemdebruijn.kernel@gmail.com,
alexander.duyck@gmail.com, linux-kernel@vger.kernel.org,
linux-net-drivers@amd.com
Subject: Re: [PATCH net-next v3 0/5] net: gso: restore outer ip ids correctly
Date: Thu, 21 Aug 2025 10:51:58 -0700 [thread overview]
Message-ID: <20250821105158.6f2fc95e@kernel.org> (raw)
In-Reply-To: <20250821073047.2091-1-richardbgobert@gmail.com>
On Thu, 21 Aug 2025 09:30:42 +0200 Richard Gobert wrote:
> GRO currently ignores outer IPv4 header IDs for encapsulated packets
> that have their don't-fragment flag set. GSO, however, always assumes
> that outer IP IDs are incrementing. This results in GSO mangling the
> outer IDs when they aren't incrementing. For example, GSO mangles the
> outer IDs of IPv6 packets that were converted to IPv4, which must
> have an ID of 0 according to RFC 6145, sect. 5.1.
>
> GRO+GSO is supposed to be entirely transparent by default. GSO already
> correctly restores inner IDs and IDs of non-encapsulated packets. The
> tx-tcp-mangleid-segmentation feature can be enabled to allow the
> mangling of such IDs so that TSO can be used.
>
> This series fixes outer ID restoration for encapsulated packets when
> tx-tcp-mangleid-segmentation is disabled. It also allows GRO to merge
> packets with fixed IDs that don't have their don't-fragment flag set.
This series appears to break GSO_PARTIAL:
https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu/results/263201/6-tso-py/stdout
--
pw-bot: cr
prev parent reply other threads:[~2025-08-21 17:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 7:30 [PATCH net-next v3 0/5] net: gso: restore outer ip ids correctly Richard Gobert
2025-08-21 7:30 ` [PATCH net-next v3 1/5] net: gro: remove is_ipv6 from napi_gro_cb Richard Gobert
2025-08-21 7:30 ` [PATCH net-next v3 2/5] net: gro: only merge packets with incrementing or fixed outer ids Richard Gobert
2025-08-22 8:26 ` Paolo Abeni
2025-08-22 8:31 ` Paolo Abeni
2025-08-21 7:30 ` [PATCH net-next v3 3/5] net: gso: restore ids of outer ip headers correctly Richard Gobert
2025-08-21 16:20 ` Edward Cree
2025-08-25 13:22 ` Richard Gobert
2025-08-22 15:51 ` Paolo Abeni
2025-08-25 13:31 ` Richard Gobert
2025-08-25 16:38 ` Paolo Abeni
2025-08-26 14:31 ` Richard Gobert
2025-08-21 7:30 ` [PATCH net-next v3 4/5] net: gro: remove unnecessary df checks Richard Gobert
2025-08-21 7:30 ` [PATCH net-next v3 5/5] selftests/net: test ipip packets in gro.sh Richard Gobert
2025-08-21 17:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821105158.6f2fc95e@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=mbloch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).