From: Dmitry Safonov via B4 Relay <devnull+dima.arista.com@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: Bob Gilligan <gilligan@arista.com>,
Salam Noureddine <noureddine@arista.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Safonov <dima@arista.com>
Subject: [PATCH net-next 0/2] tcp: Destroy TCP-AO, TCP-MD5 keys in .sk_destruct()
Date: Fri, 22 Aug 2025 05:55:35 +0100 [thread overview]
Message-ID: <20250822-b4-tcp-ao-md5-rst-finwait2-v1-0-25825d085dcb@arista.com> (raw)
On one side a minor/cosmetic issue, especially nowadays when
TCP-AO/TCP-MD5 signature verification failures aren't logged to dmesg.
Yet, I think worth addressing for two reasons:
- unsigned RST gets ignored by the peer and the connection is alive for
longer (keep-alive interval)
- netstat counters increase and trace events report that trusted BGP peer
is sending unsigned/incorrectly signed segments, which can ring alarm
on monitoring.
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
Dmitry Safonov (2):
tcp: Destroy TCP-AO, TCP-MD5 keys in .sk_destruct()
tcp: Free TCP-AO/TCP-MD5 info/keys without RCU
net/ipv4/tcp.c | 18 ++++++++++++++++++
net/ipv4/tcp_ao.c | 5 ++---
net/ipv4/tcp_ipv4.c | 29 ++---------------------------
net/ipv4/tcp_minisocks.c | 19 +++++--------------
4 files changed, 27 insertions(+), 44 deletions(-)
---
base-commit: a7bd72158063740212344fad5d99dcef45bc70d6
change-id: 20250822-b4-tcp-ao-md5-rst-finwait2-e632b4d8f58d
Best regards,
--
Dmitry Safonov <dima@arista.com>
next reply other threads:[~2025-08-22 4:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 4:55 Dmitry Safonov via B4 Relay [this message]
2025-08-22 4:55 ` [PATCH net-next 1/2] tcp: Destroy TCP-AO, TCP-MD5 keys in .sk_destruct() Dmitry Safonov via B4 Relay
2025-08-22 12:40 ` Victor Nogueira
2025-08-22 18:05 ` Dmitry Safonov
2025-08-22 19:24 ` kernel test robot
2025-08-22 4:55 ` [PATCH net-next 2/2] tcp: Free TCP-AO/TCP-MD5 info/keys without RCU Dmitry Safonov via B4 Relay
2025-08-22 9:08 ` [syzbot ci] Re: tcp: Destroy TCP-AO, TCP-MD5 keys in .sk_destruct() syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822-b4-tcp-ao-md5-rst-finwait2-v1-0-25825d085dcb@arista.com \
--to=devnull+dima.arista.com@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gilligan@arista.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).