From: "André Almeida" <andrealmeid@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Theodore Tso <tytso@mit.edu>,
Gabriel Krisman Bertazi <krisman@kernel.org>
Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
kernel-dev@igalia.com, "André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v6 2/9] fs: Create sb_same_encoding() helper
Date: Fri, 22 Aug 2025 11:17:05 -0300 [thread overview]
Message-ID: <20250822-tonyk-overlayfs-v6-2-8b6e9e604fa2@igalia.com> (raw)
In-Reply-To: <20250822-tonyk-overlayfs-v6-0-8b6e9e604fa2@igalia.com>
For cases where a file lookup can look in different filesystems (like in
overlayfs), both super blocks must have the same encoding and the same
flags. To help with that, create a sb_same_encoding() function.
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
include/linux/fs.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index a4d353a871b094b562a87ddcffe8336a26c5a3e2..7de9e1e4839a2726f4355ddf20b9babb74cc9681 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3747,6 +3747,24 @@ static inline bool sb_has_encoding(const struct super_block *sb)
return !!sb_encoding(sb);
}
+/*
+ * Compare if two super blocks have the same encoding and flags
+ */
+static inline bool sb_same_encoding(const struct super_block *sb1,
+ const struct super_block *sb2)
+{
+#if IS_ENABLED(CONFIG_UNICODE)
+ if (sb1->s_encoding == sb2->s_encoding)
+ return true;
+
+ return (sb1->s_encoding && sb2->s_encoding &&
+ (sb1->s_encoding->version == sb2->s_encoding->version) &&
+ (sb1->s_encoding_flags == sb2->s_encoding_flags));
+#else
+ return true;
+#endif
+}
+
int may_setattr(struct mnt_idmap *idmap, struct inode *inode,
unsigned int ia_valid);
int setattr_prepare(struct mnt_idmap *, struct dentry *, struct iattr *);
--
2.50.1
next prev parent reply other threads:[~2025-08-22 14:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 14:17 [PATCH v6 0/9] ovl: Enable support for casefold layers André Almeida
2025-08-22 14:17 ` [PATCH v6 1/9] fs: Create sb_encoding() helper André Almeida
2025-08-25 9:19 ` Gabriel Krisman Bertazi
2025-08-25 12:38 ` Gabriel Krisman Bertazi
2025-08-25 15:28 ` Amir Goldstein
2025-08-22 14:17 ` André Almeida [this message]
2025-08-23 10:02 ` [PATCH v6 2/9] fs: Create sb_same_encoding() helper Amir Goldstein
2025-08-25 9:24 ` Gabriel Krisman Bertazi
2025-08-22 14:17 ` [PATCH v6 3/9] ovl: Prepare for mounting case-insensitive enabled layers André Almeida
2025-08-25 10:42 ` Gabriel Krisman Bertazi
2025-08-22 14:17 ` [PATCH v6 4/9] ovl: Create ovl_casefold() to support casefolded strncmp() André Almeida
2025-08-22 16:53 ` Amir Goldstein
2025-08-25 11:09 ` Gabriel Krisman Bertazi
2025-08-25 15:27 ` Amir Goldstein
2025-08-25 15:45 ` Amir Goldstein
2025-08-25 17:11 ` Gabriel Krisman Bertazi
2025-08-26 1:34 ` Gabriel Krisman Bertazi
2025-08-26 7:19 ` Amir Goldstein
2025-08-26 15:02 ` Gabriel Krisman Bertazi
2025-08-26 19:58 ` André Almeida
2025-08-27 9:28 ` Amir Goldstein
2025-08-26 20:01 ` André Almeida
2025-08-27 20:45 ` André Almeida
2025-08-28 11:09 ` Amir Goldstein
2025-08-22 14:17 ` [PATCH v6 5/9] ovl: Ensure that all layers have the same encoding André Almeida
2025-08-25 11:17 ` Gabriel Krisman Bertazi
2025-08-25 15:32 ` Amir Goldstein
2025-08-26 20:12 ` André Almeida
2025-08-27 9:17 ` Amir Goldstein
2025-08-22 14:17 ` [PATCH v6 6/9] ovl: Set case-insensitive dentry operations for ovl sb André Almeida
2025-08-25 11:24 ` Gabriel Krisman Bertazi
2025-08-25 15:34 ` Amir Goldstein
2025-08-26 20:13 ` André Almeida
2025-08-22 14:17 ` [PATCH v6 7/9] ovl: Add S_CASEFOLD as part of the inode flag to be copied André Almeida
2025-08-22 14:17 ` [PATCH v6 8/9] ovl: Check for casefold consistency when creating new dentries André Almeida
2025-08-22 14:17 ` [PATCH v6 9/9] ovl: Support mounting case-insensitive enabled layers André Almeida
2025-08-22 16:34 ` Amir Goldstein
2025-08-22 16:47 ` André Almeida
2025-08-22 19:17 ` Amir Goldstein
2025-08-25 13:31 ` André Almeida
2025-08-26 7:31 ` Amir Goldstein
2025-08-26 19:01 ` André Almeida
2025-08-27 18:06 ` Amir Goldstein
2025-08-27 20:37 ` André Almeida
2025-08-27 23:58 ` NeilBrown
2025-08-28 3:15 ` Gabriel Krisman Bertazi
2025-08-28 7:25 ` Amir Goldstein
2025-08-28 16:44 ` Amir Goldstein
2025-08-29 1:27 ` NeilBrown
2025-08-29 1:25 ` NeilBrown
2025-08-29 9:31 ` Amir Goldstein
2025-09-01 22:02 ` NeilBrown
2025-08-22 19:28 ` [syzbot ci] Re: ovl: Enable support for casefold layers syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822-tonyk-overlayfs-v6-2-8b6e9e604fa2@igalia.com \
--to=andrealmeid@igalia.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).