From: "André Almeida" <andrealmeid@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Theodore Tso <tytso@mit.edu>,
Gabriel Krisman Bertazi <krisman@kernel.org>
Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
kernel-dev@igalia.com, "André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v6 6/9] ovl: Set case-insensitive dentry operations for ovl sb
Date: Fri, 22 Aug 2025 11:17:09 -0300 [thread overview]
Message-ID: <20250822-tonyk-overlayfs-v6-6-8b6e9e604fa2@igalia.com> (raw)
In-Reply-To: <20250822-tonyk-overlayfs-v6-0-8b6e9e604fa2@igalia.com>
For filesystems with encoding (i.e. with case-insensitive support), set
the dentry operations for the super block as ovl_dentry_ci_operations.
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
Changes in v6:
- Fix kernel bot warning: unused variable 'ofs'
---
fs/overlayfs/super.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index b1dbd3c79961094d00c7f99cc622e515d544d22f..8db4e55d5027cb975fec9b92251f62fe5924af4f 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -161,6 +161,16 @@ static const struct dentry_operations ovl_dentry_operations = {
.d_weak_revalidate = ovl_dentry_weak_revalidate,
};
+#if IS_ENABLED(CONFIG_UNICODE)
+static const struct dentry_operations ovl_dentry_ci_operations = {
+ .d_real = ovl_d_real,
+ .d_revalidate = ovl_dentry_revalidate,
+ .d_weak_revalidate = ovl_dentry_weak_revalidate,
+ .d_hash = generic_ci_d_hash,
+ .d_compare = generic_ci_d_compare,
+};
+#endif
+
static struct kmem_cache *ovl_inode_cachep;
static struct inode *ovl_alloc_inode(struct super_block *sb)
@@ -1332,6 +1342,19 @@ static struct dentry *ovl_get_root(struct super_block *sb,
return root;
}
+static void ovl_set_d_op(struct super_block *sb)
+{
+#if IS_ENABLED(CONFIG_UNICODE)
+ struct ovl_fs *ofs = sb->s_fs_info;
+
+ if (ofs->casefold) {
+ set_default_d_op(sb, &ovl_dentry_ci_operations);
+ return;
+ }
+#endif
+ set_default_d_op(sb, &ovl_dentry_operations);
+}
+
int ovl_fill_super(struct super_block *sb, struct fs_context *fc)
{
struct ovl_fs *ofs = sb->s_fs_info;
@@ -1443,6 +1466,8 @@ int ovl_fill_super(struct super_block *sb, struct fs_context *fc)
if (IS_ERR(oe))
goto out_err;
+ ovl_set_d_op(sb);
+
/* If the upper fs is nonexistent, we mark overlayfs r/o too */
if (!ovl_upper_mnt(ofs))
sb->s_flags |= SB_RDONLY;
--
2.50.1
next prev parent reply other threads:[~2025-08-22 14:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 14:17 [PATCH v6 0/9] ovl: Enable support for casefold layers André Almeida
2025-08-22 14:17 ` [PATCH v6 1/9] fs: Create sb_encoding() helper André Almeida
2025-08-25 9:19 ` Gabriel Krisman Bertazi
2025-08-25 12:38 ` Gabriel Krisman Bertazi
2025-08-25 15:28 ` Amir Goldstein
2025-08-22 14:17 ` [PATCH v6 2/9] fs: Create sb_same_encoding() helper André Almeida
2025-08-23 10:02 ` Amir Goldstein
2025-08-25 9:24 ` Gabriel Krisman Bertazi
2025-08-22 14:17 ` [PATCH v6 3/9] ovl: Prepare for mounting case-insensitive enabled layers André Almeida
2025-08-25 10:42 ` Gabriel Krisman Bertazi
2025-08-22 14:17 ` [PATCH v6 4/9] ovl: Create ovl_casefold() to support casefolded strncmp() André Almeida
2025-08-22 16:53 ` Amir Goldstein
2025-08-25 11:09 ` Gabriel Krisman Bertazi
2025-08-25 15:27 ` Amir Goldstein
2025-08-25 15:45 ` Amir Goldstein
2025-08-25 17:11 ` Gabriel Krisman Bertazi
2025-08-26 1:34 ` Gabriel Krisman Bertazi
2025-08-26 7:19 ` Amir Goldstein
2025-08-26 15:02 ` Gabriel Krisman Bertazi
2025-08-26 19:58 ` André Almeida
2025-08-27 9:28 ` Amir Goldstein
2025-08-26 20:01 ` André Almeida
2025-08-27 20:45 ` André Almeida
2025-08-28 11:09 ` Amir Goldstein
2025-08-22 14:17 ` [PATCH v6 5/9] ovl: Ensure that all layers have the same encoding André Almeida
2025-08-25 11:17 ` Gabriel Krisman Bertazi
2025-08-25 15:32 ` Amir Goldstein
2025-08-26 20:12 ` André Almeida
2025-08-27 9:17 ` Amir Goldstein
2025-08-22 14:17 ` André Almeida [this message]
2025-08-25 11:24 ` [PATCH v6 6/9] ovl: Set case-insensitive dentry operations for ovl sb Gabriel Krisman Bertazi
2025-08-25 15:34 ` Amir Goldstein
2025-08-26 20:13 ` André Almeida
2025-08-22 14:17 ` [PATCH v6 7/9] ovl: Add S_CASEFOLD as part of the inode flag to be copied André Almeida
2025-08-22 14:17 ` [PATCH v6 8/9] ovl: Check for casefold consistency when creating new dentries André Almeida
2025-08-22 14:17 ` [PATCH v6 9/9] ovl: Support mounting case-insensitive enabled layers André Almeida
2025-08-22 16:34 ` Amir Goldstein
2025-08-22 16:47 ` André Almeida
2025-08-22 19:17 ` Amir Goldstein
2025-08-25 13:31 ` André Almeida
2025-08-26 7:31 ` Amir Goldstein
2025-08-26 19:01 ` André Almeida
2025-08-27 18:06 ` Amir Goldstein
2025-08-27 20:37 ` André Almeida
2025-08-27 23:58 ` NeilBrown
2025-08-28 3:15 ` Gabriel Krisman Bertazi
2025-08-28 7:25 ` Amir Goldstein
2025-08-28 16:44 ` Amir Goldstein
2025-08-29 1:27 ` NeilBrown
2025-08-29 1:25 ` NeilBrown
2025-08-29 9:31 ` Amir Goldstein
2025-09-01 22:02 ` NeilBrown
2025-08-22 19:28 ` [syzbot ci] Re: ovl: Enable support for casefold layers syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822-tonyk-overlayfs-v6-6-8b6e9e604fa2@igalia.com \
--to=andrealmeid@igalia.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=krisman@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).