From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19AB726F2BB; Fri, 22 Aug 2025 07:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755846258; cv=none; b=klw0P9CraLChcd/0kIrSDbYxCzdvKncZqBDcb3tDCER/V5ycDiE6lsymahS1cdvtXaYtf1fGoIEcyJ7tH7uOQo521Jfjc8/rLVmghJZhqLgCp6mMJ/CoYs4v6sBb9t7UqUuXfAksUgT4F3LWAVgk9Axqq/8YJ4WV19uvBcxrBgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755846258; c=relaxed/simple; bh=//iPq+9seSBsOGcSgTuoPGVpO2xMrH5yo+zOJJIOObo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b0ljk3ZftC//bRh9v5rK5YfZnZQ+5684MSt0Cwo6gdCKoTJQeuL/N0IT6ZuO5CcGlMcj0WtenRmAQ7682a6yOD+hq1RNxKdmnhhZoNZtjTdcQJXZJwFvszEMXGBZteB9LGmw0PjbnFhaYm3oE3kg9Ba194X6DsEsTYQyrpqKSX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=naW0xum0; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="naW0xum0" Received: from francesco-nb (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch [83.173.201.248]) by mail11.truemail.it (Postfix) with ESMTPA id 468631F90C; Fri, 22 Aug 2025 09:04:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1755846245; bh=b3LB6AKLWtMRp7LJqzHFsQOELisaDWWfVYYsVajcePw=; h=From:To:Subject; b=naW0xum0rU7DNLezdhgLXYO/DYFEaWP2QDWzKZlUDUB4QISseWgnYJobWbTQNF1E6 QjDPI92c8+wyXU77PgXu404whBJOvdMCFq92CXmgI2hbzeH6JtUh6wKobFif2WOAXb YfFUvbvfQrWRfVeB7AJ2vFzH2D49Tei+0Q7mG/9G+vxmFa/EWcCTxzzw/KtXu0G4JC Q7rR/NDP4JYSavNrX0mUWS0N0qtlVg/3JhyDRKwA47YBib6F20eSvuwYpoImUtbh8s lSD+lBnuqaRNc1oBk/OHWfBN/FqyL41x14gTm/qb2N+S/ZSqJXBg/se9qiiKS6rx3a 4oO4occyk5T2g== Date: Fri, 22 Aug 2025 09:04:01 +0200 From: Francesco Dolcini To: Tomi Valkeinen Cc: Vitor Soares , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vitor Soares , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Aradhya Bhatia , Jayesh Choudhary , stable@vger.kernel.org Subject: Re: [PATCH v3] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Message-ID: <20250822070401.GA15925@francesco-nb> References: <20250512083215.436149-1-ivitro@gmail.com> <546ef388-299b-4d97-8633-9508fab4475a@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546ef388-299b-4d97-8633-9508fab4475a@ideasonboard.com> Hello, On Thu, May 22, 2025 at 12:09:08PM +0300, Tomi Valkeinen wrote: > On 12/05/2025 11:32, Vitor Soares wrote: > > From: Vitor Soares > > > > The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks > > for both runtime PM and system sleep. This causes the DSI clocks to be > > disabled twice: once during runtime suspend and again during system > > suspend, resulting in a WARN message from the clock framework when > > attempting to disable already-disabled clocks. > > > > [ 84.384540] clk:231:5 already disabled > > [ 84.388314] WARNING: CPU: 2 PID: 531 at /drivers/clk/clk.c:1181 clk_core_disable+0xa4/0xac > > ... > > [ 84.579183] Call trace: > > [ 84.581624] clk_core_disable+0xa4/0xac > > [ 84.585457] clk_disable+0x30/0x4c > > [ 84.588857] cdns_dsi_suspend+0x20/0x58 [cdns_dsi] > > [ 84.593651] pm_generic_suspend+0x2c/0x44 > > [ 84.597661] ti_sci_pd_suspend+0xbc/0x15c > > [ 84.601670] dpm_run_callback+0x8c/0x14c > > [ 84.605588] __device_suspend+0x1a0/0x56c > > [ 84.609594] dpm_suspend+0x17c/0x21c > > [ 84.613165] dpm_suspend_start+0xa0/0xa8 > > [ 84.617083] suspend_devices_and_enter+0x12c/0x634 > > [ 84.621872] pm_suspend+0x1fc/0x368 > > > > To address this issue, replace UNIVERSAL_DEV_PM_OPS() with > > SET_RUNTIME_PM_OPS(), enabling suspend/resume handling through the > > _enable()/_disable() hooks managed by the DRM framework for both > > runtime and system-wide PM. > > > > Cc: # 6.1.x > > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > > Signed-off-by: Vitor Soares ping on this, Tomi, maybe you can pick this one or is there any concern ? Francesco