* [PATCH v3] serial: 8250_core: fix coding style issue
@ 2025-08-22 9:56 Osama Abdelkader
2025-08-22 10:19 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2025-08-22 9:56 UTC (permalink / raw)
To: gregkh, jirislaby, ilpo.jarvinen, mingo, john.ogness, tglx
Cc: linux-kernel, linux-serial, Osama Abdelkader
Fix a coding style issue in 8250_core.c:
- Remove redundant NULL initialization of a global pointer
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
v2:
- Dropped extra blank line after gpios declaration
v3:
- Added changelog to commit message
---
drivers/tty/serial/8250/8250_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index feb920c5b2e8..225bb7e4b89c 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
serial_unlink_irq_chain(up);
}
-const struct uart_ops *univ8250_port_base_ops = NULL;
+const struct uart_ops *univ8250_port_base_ops;
struct uart_ops univ8250_port_ops;
static const struct uart_8250_ops univ8250_driver_ops = {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] serial: 8250_core: fix coding style issue
2025-08-22 9:56 [PATCH v3] serial: 8250_core: fix coding style issue Osama Abdelkader
@ 2025-08-22 10:19 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2025-08-22 10:19 UTC (permalink / raw)
To: Osama Abdelkader, gregkh, ilpo.jarvinen, mingo, john.ogness, tglx
Cc: linux-kernel, linux-serial
On 22. 08. 25, 11:56, Osama Abdelkader wrote:
> Fix a coding style issue in 8250_core.c:
>
> - Remove redundant NULL initialization of a global pointer
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
FWIW
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-22 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 9:56 [PATCH v3] serial: 8250_core: fix coding style issue Osama Abdelkader
2025-08-22 10:19 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).