* [PATCH] usb: phy: twl6030: Fix incorrect type for ret
@ 2025-08-22 8:14 Xichao Zhao
2025-08-22 8:45 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Xichao Zhao @ 2025-08-22 8:14 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Xichao Zhao
In the twl6030_usb_probe(), the variable ret is declared as
a u32 type. However, since ret may receive -ENODEV when accepting
the return value of omap_usb2_set_comparator().Therefore, its type
should be changed to int.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/usb/phy/phy-twl6030-usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
index 49d79c1257f3..8c09db750bfd 100644
--- a/drivers/usb/phy/phy-twl6030-usb.c
+++ b/drivers/usb/phy/phy-twl6030-usb.c
@@ -328,9 +328,8 @@ static int twl6030_set_vbus(struct phy_companion *comparator, bool enabled)
static int twl6030_usb_probe(struct platform_device *pdev)
{
- u32 ret;
struct twl6030_usb *twl;
- int status, err;
+ int status, err, ret;
struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: phy: twl6030: Fix incorrect type for ret
2025-08-22 8:14 [PATCH] usb: phy: twl6030: Fix incorrect type for ret Xichao Zhao
@ 2025-08-22 8:45 ` Greg KH
2025-08-22 9:49 ` 赵西超
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2025-08-22 8:45 UTC (permalink / raw)
To: Xichao Zhao; +Cc: linux-usb, linux-kernel
On Fri, Aug 22, 2025 at 04:14:03PM +0800, Xichao Zhao wrote:
> In the twl6030_usb_probe(), the variable ret is declared as
> a u32 type. However, since ret may receive -ENODEV when accepting
> the return value of omap_usb2_set_comparator().Therefore, its type
> should be changed to int.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
> drivers/usb/phy/phy-twl6030-usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: phy: twl6030: Fix incorrect type for ret
2025-08-22 8:45 ` Greg KH
@ 2025-08-22 9:49 ` 赵西超
0 siblings, 0 replies; 3+ messages in thread
From: 赵西超 @ 2025-08-22 9:49 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
> On Fri, Aug 22, 2025 at 04:14:03PM +0800, Xichao Zhao wrote:
>> In the twl6030_usb_probe(), the variable ret is declared as
>> a u32 type. However, since ret may receive -ENODEV when accepting
>> the return value of omap_usb2_set_comparator().Therefore, its type
>> should be changed to int.
>>
>> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
>> ---
>> drivers/usb/phy/phy-twl6030-usb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
> What commit id does this fix?
>
> thanks,
>
> greg k-h
I have added the fixes and sent out the v2 version of the patch.
Best Regards,
Xichao Zhao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-22 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 8:14 [PATCH] usb: phy: twl6030: Fix incorrect type for ret Xichao Zhao
2025-08-22 8:45 ` Greg KH
2025-08-22 9:49 ` 赵西超
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).