From: Bjorn Helgaas <helgaas@kernel.org>
To: Marcos Del Sol Vives <marcos@orca.pet>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Michael Walle <mwalle@kernel.org>, Lee Jones <lee@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 2/3] gpio: vortex: add new GPIO device driver
Date: Fri, 22 Aug 2025 10:49:03 -0500 [thread overview]
Message-ID: <20250822154903.GA685390@bhelgaas> (raw)
In-Reply-To: <20250822154718.GA685150@bhelgaas>
On Fri, Aug 22, 2025 at 10:47:20AM -0500, Bjorn Helgaas wrote:
> On Thu, Aug 21, 2025 at 07:05:16PM +0200, Marcos Del Sol Vives wrote:
> > El 21/08/2025 a las 12:18, Marcos Del Sol Vives escribió:
> > > +#include <linux/types.h>
> > > +#include <linux/errno.h>
> > > +#include <linux/module.h>
> > > +#include <linux/ioport.h>
> > > +#include <linux/spinlock.h>
> > > +#include <linux/gpio/driver.h>
> > > +#include <linux/gpio/regmap.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/ioport.h>
> > > +#include <linux/types.h>
> > > +#include <linux/platform_device.h>
> >
> > I realized now that, despite checking over and over the patches before
> > sending to the mailing list, I forgot to clean up leftover includes from
> > previous versions of the driver.
> >
> > I am fairly new to this procedure of merging patches. Should I later, after
> > a send a sensible amount of time has passed to let everyone voice their
> > opinion, send a new v4 version of the patch to fix these (and also clarify
> > the commit message on the regmap-gpio, as requested in another email),
> > or if accepted would maybe the person merging it sort this out?
>
> I'm not the person to merge this, but my advice is to wait a few days
> and post a v4 that cleans up the includes and updates the commit
> messages. It makes the process cleaner if the patch you post is the
> same as the one that gets merged.
Sorry for the noise, should have read farther through my email :)
next prev parent reply other threads:[~2025-08-22 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 10:18 [PATCH v3 0/3] Introduce support for Vortex GPIO pins Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 1/3] gpio: gpio-regmap: add flags to control some behaviour Marcos Del Sol Vives
2025-08-21 14:32 ` Bjorn Helgaas
2025-08-21 17:14 ` Marcos Del Sol Vives
2025-08-21 16:40 ` Linus Walleij
2025-08-22 7:07 ` Michael Walle
2025-08-22 11:04 ` Marcos Del Sol Vives
2025-08-22 3:27 ` kernel test robot
2025-08-22 11:11 ` Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 2/3] gpio: vortex: add new GPIO device driver Marcos Del Sol Vives
2025-08-21 16:48 ` Linus Walleij
2025-08-21 17:05 ` Marcos Del Sol Vives
2025-08-22 15:47 ` Bjorn Helgaas
2025-08-22 15:49 ` Bjorn Helgaas [this message]
2025-08-22 16:08 ` Marcos Del Sol Vives
2025-08-21 10:18 ` [PATCH v3 3/3] mfd: vortex: implement new driver for Vortex southbridges Marcos Del Sol Vives
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822154903.GA685390@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcos@orca.pet \
--cc=mwalle@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox