The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriele Paoloni <gpaoloni@redhat.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	safety-architecture@lists.elisa.tech,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC PATCH] /dev/mem: Add initial documentation of memory_open() and mem_fops
Date: Sat, 23 Aug 2025 10:01:03 +0200	[thread overview]
Message-ID: <2025082352-ending-immerse-fee4@gregkh> (raw)
In-Reply-To: <CA+wEVJZntQ6Fx8VWzL-PpKWw7=vxKQewxkUfu_f01Px2EFtRZQ@mail.gmail.com>

On Sat, Aug 23, 2025 at 09:48:32AM +0200, Gabriele Paoloni wrote:
> > > > > + * - The file position '*ppos' shall be advanced by the number of bytes
> > > > > + *   successfully copied from user space (including skipped bytes).
> > > >
> > > > No short summary first of what the function is supposed to do normally?
> > > > Or are you relying on the few words at the top to summarize that?
> > >
> > > Function's expectations would define the testable behaviours (so they
> > > are broken down into detailed expectations); nothing prevents to provide
> > > an informative intro above "Function's expectations"; I could clarify this
> > > in the patch for the doc-guide  and revisit this patch with informative intros
> > > for all the functions....
> >
> > "testable behavior" is going to be very hard given that you are
> > describing an internal-to-the-kernel function.  Good luck!
> 
> Well that is something to be figured out (step by step :-) )

Well what is your end-goal here?  Do you need/want all functions in the
kernel to be documented like this, or do you only want those that are
describing user-visable functionality?

What is the requirement that is causing you to do this work?

thanks,

greg k-h

  reply	other threads:[~2025-08-23  8:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 17:04 [RFC PATCH] /dev/mem: Add initial documentation of memory_open() and mem_fops Gabriele Paoloni
2025-08-21 17:14 ` Greg KH
2025-08-22 14:43   ` Gabriele Paoloni
2025-08-22 15:08     ` Greg KH
2025-08-23  7:48       ` Gabriele Paoloni
2025-08-23  8:01         ` Greg KH [this message]
2025-08-24 15:09           ` Gabriele Paoloni
2025-08-21 17:35 ` Greg KH
2025-08-22 15:14   ` Gabriele Paoloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025082352-ending-immerse-fee4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=gpaoloni@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=safety-architecture@lists.elisa.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox