From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53883019DF for ; Mon, 25 Aug 2025 14:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756131541; cv=none; b=anJtSeGwsBPoo3CAh698pG/2tVh/0VmgjvdoK6aTErwShlL12oE+rk8kZArjWApqBFgWs5gnlvTltextlacATlVc1ZIdbaguEeCJnggyZmz2aWvQ6fDtC0cRfOquy/eSO+E9Se8+F4/MTItmfUOd52FjfXXwaGL0u0BzGbPBPtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756131541; c=relaxed/simple; bh=09dlpQFv1ezXWuJr098HED8/TB54QMuuNRmjzT3slmY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=btX51PHrlow/fO8b6xyEVISq8Ir2YUdfXThG19s5rjZnCiJDO2/ft/qnPGwGfydW5NEdQnt3SVFgta6nUaTDRKhdwo8tadvcP8CxCJYNc+2ZyhQ+eBV3WEpSrev4RcYIBKPrJEw2F7KFjtUPL0SI9krclQjyRPDA4JWgNOaZAdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hLfLV2Q7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hLfLV2Q7" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57P8eovs015247 for ; Mon, 25 Aug 2025 14:18:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d4em/xcDonNf4m1zVAyxC0QlLlKFxyiAEUK6Ca1lpXA=; b=hLfLV2Q7e/tX9PDH 8tY9n7qGH4XqYK9E8CLSsndvGf9zENYtnZzQY/sH8GrYKCo1RN0M0r7PKNvOj6iq lQED+8goMLEL9awCENLCbdqJRXyjOkHAu3yk202ibX9y4GrqEBc9vZykHlS3lTbO xIxlqL6tqynqZZCQzGjkLmp0ILEhw+JdRVtfIIUydoB7PDIYzwN4MRruIJqMsTIr /lx+1wX/d6sTa4nKAfv8pcyneW59p6uIfbvnchgDUKDX0XYUGGP4WjCVnuETVuRD 16YQAvL5jfxIrjVnF1owZvm2Ro1WVTJ+xNgHtuXcJdb+rLqXMqKFW/qMy7VF/6dm m6rwKg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q6x85ber-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 25 Aug 2025 14:18:58 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-76e2e60221fso8836638b3a.0 for ; Mon, 25 Aug 2025 07:18:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756131538; x=1756736338; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d4em/xcDonNf4m1zVAyxC0QlLlKFxyiAEUK6Ca1lpXA=; b=o77TVN704kbya+yG6jVcMHd8C09sn/foqvcadwImEJNZoPUTivMPU9kgzMQy+JaJ8b BfeRUiReQk09Xdb7EH2eS9G4NHHl125cXCTfxrM1OTZS6QQ+hIiLkRbAS4nhO3si4vfg qPTgyEti4GjjWxfpGE3ZeuJHtN0k6Es8qkxnFmGkPVBj1Dn6LL0KXqc9KfHqnW1jvRjo CcEuOnanbzKuJlxXqPn3+SgGY8YLH27MbvbvStgWPpJY9v2uz7kjItSexAAHztdclr4k 2tFwNKvW2ppK0sJ5zfLpaZ/3enp2EX0ZRqeknRXcP6+Op8M8uvKLlzFbucnY+mTwBSkJ dXKw== X-Forwarded-Encrypted: i=1; AJvYcCX6Q9ihXbKx6E0SxxdLFdUfrPEUVfgRaknPPhA1cdoLKtmZnWBPPuRHmEVcTAAltfU6+lZba00NpdMu/NI=@vger.kernel.org X-Gm-Message-State: AOJu0YxMpCOgzxewkhzNeS2+9edgHx2pnfXG6Z8L6hKucNkUYn/9rI5q vo7oZ2IxVCxOzEpD1kldIJKDG1VOXyQEUhZkXcRzoVaUCzyCQQgAtxBBGWNoamMsIzgYlFVSnYf yHWo0/ku6zsvaps+yKDYfEt8l1nFI0gMD9dilcA+vcu6qp1hjYD8o0GilVuQVQr6hETw= X-Gm-Gg: ASbGnctcX3Lzix+pggUbdDfLib/a6IWNtElTfWI+cuDRq3MjY+hD8jIHhwXc0EUR3iA L/lsosT9h6qFItKx3ya94SHX8HyviGtWrEov8faZVQgsZmB1nU0tOkXouhUrqWF71m2xtG04hAy kfb1ggRMA6owYSewtA7KVj9Q6MCbmWw7N9kYp9IenwqY3QXB6J1AYIeCFLxgqrWXonqCWGUTzkI MMS+1JP14JgFeJYJUv0oUFnaxLTRRtiHHqyBHRSs2n3sSi1eqGb51LrR3pndb5ulPm1AADhEg+3 4johCgf9hYQz1Vr4tCOgpeFFYx5JZ5Fz9nYqh8qkdF1o/H3zJY/m2dbMEyYxKdPVtUvWxyE= X-Received: by 2002:a05:6a00:190e:b0:757:ca2b:48a3 with SMTP id d2e1a72fcca58-7702fa048d1mr16349137b3a.9.1756131538012; Mon, 25 Aug 2025 07:18:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcONK9QkiksV2iPZcOMhRszPAf8sw61weQPpzMqGsQNFrglfJdpF3Bk+hpt3laf8w+p1QW4A== X-Received: by 2002:a05:6a00:190e:b0:757:ca2b:48a3 with SMTP id d2e1a72fcca58-7702fa048d1mr16349105b3a.9.1756131537494; Mon, 25 Aug 2025 07:18:57 -0700 (PDT) Received: from cse-cd01-lnx.ap.qualcomm.com ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-770401eb20dsm7672339b3a.79.2025.08.25.07.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Aug 2025 07:18:57 -0700 (PDT) From: Yongxing Mou Date: Mon, 25 Aug 2025 22:16:12 +0800 Subject: [PATCH v3 26/38] drm/msm/dp: add an API to initialize MST on sink side Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250825-msm-dp-mst-v3-26-01faacfcdedd@oss.qualcomm.com> References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> In-Reply-To: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1756131423; l=3420; i=yongxing.mou@oss.qualcomm.com; s=20241121; h=from:subject:message-id; bh=5rW/DfearqD7fwWZSsWrOun0WURd1EIi5z5yGV9n+1M=; b=EY7yhkz4fOACWjsghjS0efOMUzJwNpOWAwybbpu4RG1f01cD4hxc0M9fMrEN+mSjA4a4SCHrw JVNssBx1X0eCD1oIrpidZaR33X6TqT23B7AphT/54EqCJIX9ahQgaep X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=zeCnFRUqtOQMeFvdwex2M5o0Yf67UHYfwCyBRQ3kFbU= X-Proofpoint-ORIG-GUID: xkmzuq5WmoolKB0cx8wRyYWH1Ov2Dwzt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDA0NCBTYWx0ZWRfX04wdB0F8KTzt DTLsh2UBbXX88kIj9M+SwpWhBlbnLuPxwV2/Y0QUstH/jnXzpQBq+giXIOztA2ctE4YTN8Okbdx cRSwffPyZp9Xf4HKgv0ARNf9lDUlsajQ/fItCwLybWsJaVAw2NrnhzqqC7rA+r5shNTSD857X7C GUa013js1EX9thFInxSnmunhWoXrud4CJKfFjfHRpL22jDc6jKUEhNRbpnbQc1VzW/MM1E0kOaL LDKwReXKWn4cxApD62byzJGuEoJQkjDhRPpa9aLmPifKTxSj7ORmumFlWJarYIeVvQfhOqENu/H khj98W7mwBDC37gEJronCLPeDw2Pl/SN4FJIPIY4f7EwQa97yRBVvVP/khfq6Tg1rpsGnPuuiYW iVbCiS6a X-Proofpoint-GUID: xkmzuq5WmoolKB0cx8wRyYWH1Ov2Dwzt X-Authority-Analysis: v=2.4 cv=Ep/SrTcA c=1 sm=1 tr=0 ts=68ac70d2 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=vCCEq3Mv4WXTdc8uXsoA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-25_06,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230044 From: Abhinav Kumar If the DP controller is capable of supporting multiple streams then initialize the DP sink in MST mode by programming the DP_MSTM_CTRL DPCD register to enable MST mode. Signed-off-by: Abhinav Kumar Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 55 ++++++++++++++++++++++++++++++------- 1 file changed, 45 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index cb433103d439ac6b8089bdecf0ee6be35c914db1..84df34306fb557341bea288ea8c13b0c81b11919 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include "msm_drv.h" @@ -297,6 +298,35 @@ static int msm_dp_display_lttpr_init(struct msm_dp_display_private *dp, u8 *dpcd return lttpr_count; } +static void msm_dp_display_mst_init(struct msm_dp_display_private *dp) +{ + const unsigned long clear_mstm_ctrl_timeout_us = 100000; + u8 old_mstm_ctrl; + struct msm_dp *msm_dp = &dp->msm_dp_display; + int ret; + + /* clear sink mst state */ + drm_dp_dpcd_readb(dp->aux, DP_MSTM_CTRL, &old_mstm_ctrl); + drm_dp_dpcd_writeb(dp->aux, DP_MSTM_CTRL, 0); + + /* add extra delay if MST old state is on*/ + if (old_mstm_ctrl) { + drm_dbg_dp(dp->drm_dev, "wait %luus to set DP_MSTM_CTRL set 0\n", + clear_mstm_ctrl_timeout_us); + usleep_range(clear_mstm_ctrl_timeout_us, + clear_mstm_ctrl_timeout_us + 1000); + } + + ret = drm_dp_dpcd_writeb(dp->aux, DP_MSTM_CTRL, + DP_MST_EN | DP_UP_REQ_EN | DP_UPSTREAM_IS_SRC); + if (ret < 0) { + DRM_ERROR("sink mst enablement failed\n"); + return; + } + + msm_dp->mst_active = true; +} + static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) { struct drm_connector *connector = dp->msm_dp_display.connector; @@ -315,18 +345,20 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) if (rc) goto end; - drm_edid = drm_edid_read_ddc(connector, &dp->aux->ddc); - drm_edid_connector_update(connector, drm_edid); + if (!dp->mst_supported || !drm_dp_read_mst_cap(dp->aux, dp->panel->dpcd)) { + drm_edid = drm_edid_read_ddc(connector, &dp->aux->ddc); + drm_edid_connector_update(connector, drm_edid); - if (!drm_edid) { - DRM_ERROR("panel edid read failed\n"); - /* check edid read fail is due to unplug */ - if (!msm_dp_aux_is_link_connected(dp->aux)) - return -ETIMEDOUT; - } + if (!drm_edid) { + DRM_ERROR("panel edid read failed\n"); + /* check edid read fail is due to unplug */ + if (!msm_dp_aux_is_link_connected(dp->aux)) + return -ETIMEDOUT; + } - if (rc) - goto end; + if (rc) + goto end; + } msm_dp_link_process_request(dp->link); @@ -349,6 +381,9 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) */ msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); + if (dp->mst_supported && drm_dp_read_mst_cap(dp->aux, dp->panel->dpcd)) + msm_dp_display_mst_init(dp); + msm_dp_link_reset_phy_params_vx_px(dp->link); if (!dp->msm_dp_display.internal_hpd) -- 2.34.1