[PATCH] genirq/debugfs: Fix a typo in IRQ effective affinity

[PATCH] genirq/debugfs: Fix a typo in IRQ effective affinity

[Ricardo Neri]

Fix a typo in the line that prints the effective affinity of the IRQ.

Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
 kernel/irq/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/debugfs.c b/kernel/irq/debugfs.c
index 3527defd2890..ee5e70751e83 100644
--- a/kernel/irq/debugfs.c
+++ b/kernel/irq/debugfs.c
@@ -30,7 +30,7 @@ static void irq_debug_show_masks(struct seq_file *m, struct irq_desc *desc)
 	seq_printf(m, "affinity: %*pbl\n", cpumask_pr_args(msk));
 #ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK
 	msk = irq_data_get_effective_affinity_mask(data);
-	seq_printf(m, "effectiv: %*pbl\n", cpumask_pr_args(msk));
+	seq_printf(m, "effective: %*pbl\n", cpumask_pr_args(msk));
 #endif
 #ifdef CONFIG_GENERIC_PENDING_IRQ
 	msk = desc->pending_mask;

---
base-commit: f6636ec7a7297f6ce226fae06ba6ace5419d38cd
change-id: 20250812-rneri-irq-debugfs-typo-2fb5e86c9198

Best regards,
-- 
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>

Re: [PATCH] genirq/debugfs: Fix a typo in IRQ effective affinity

[Thomas Gleixner]

On Tue, Aug 12 2025 at 14:00, Ricardo Neri wrote:
> Fix a typo in the line that prints the effective affinity of the IRQ.

It's not a typo. It's intentionally shortened to make the output
tabular, which makes it more readable.

If you want 'effective' then please adjust 'affinity:' with an extra
space so it stays that way.

Thanks,

        tglx

Re: [PATCH] genirq/debugfs: Fix a typo in IRQ effective affinity

[Ricardo Neri]

On Sat, Aug 23, 2025 at 07:49:12PM +0200, Thomas Gleixner wrote:
> On Tue, Aug 12 2025 at 14:00, Ricardo Neri wrote:
> > Fix a typo in the line that prints the effective affinity of the IRQ.
> 
> It's not a typo. It's intentionally shortened to make the output
> tabular, which makes it more readable.

Ah, I didn't see it this way.

> 
> If you want 'effective' then please adjust 'affinity:' with an extra
> space so it stays that way.

Sure. I can do this.

Thanks for your reply!

BR,
Ricardo

Re: [PATCH] genirq/debugfs: Fix a typo in IRQ effective affinity

[Ricardo Neri]

On Mon, Aug 25, 2025 at 04:10:54PM -0700, Ricardo Neri wrote:
> On Sat, Aug 23, 2025 at 07:49:12PM +0200, Thomas Gleixner wrote:
> > On Tue, Aug 12 2025 at 14:00, Ricardo Neri wrote:
> > > Fix a typo in the line that prints the effective affinity of the IRQ.
> > 
> > It's not a typo. It's intentionally shortened to make the output
> > tabular, which makes it more readable.
> 
> Ah, I didn't see it this way.
> 
> > 
> > If you want 'effective' then please adjust 'affinity:' with an extra
> > space so it stays that way.
> 
> Sure. I can do this.

I looked again at my proposed change. I would need to adjust 10 more lines
besides 'affinity:' to keep the alignment. Adjusting a couple of lines
would not pollute history much. Adjusting multiple lines would do more harm
than good, IMO.

Unless you think otherwise, I do not plan to pursue this change further.
 
BR,
Ricardo