* [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names
@ 2025-08-26 15:16 Frank Li
2025-08-26 23:55 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2025-08-26 15:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Allow pattern like "pclk" and "hclk" as clock-names.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
https://lore.kernel.org/linux-i3c/20250625200451.GA2117971-robh@kernel.org/
---
Documentation/devicetree/bindings/writing-bindings.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/writing-bindings.rst b/Documentation/devicetree/bindings/writing-bindings.rst
index 667816dd7d504..81f76ca57a394 100644
--- a/Documentation/devicetree/bindings/writing-bindings.rst
+++ b/Documentation/devicetree/bindings/writing-bindings.rst
@@ -97,7 +97,8 @@ Typical cases and caveats
constraints (e.g. list of items).
- For names used in {clock,dma,interrupt,reset}-names, do not add any suffix,
- e.g.: "tx" instead of "txirq" (for interrupt).
+ e.g.: "tx" instead of "txirq" (for interrupt). Except when only single letter
+ remains after removing the suffix, e.g., 'pclk', 'hclk'.
- Properties without schema types (e.g. without standard suffix or not defined
by schema) need the type, even if this is an enum.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names
2025-08-26 15:16 [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names Frank Li
@ 2025-08-26 23:55 ` Rob Herring
2025-08-27 15:23 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2025-08-26 23:55 UTC (permalink / raw)
To: Frank Li
Cc: Krzysztof Kozlowski, Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Tue, Aug 26, 2025 at 11:16:49AM -0400, Frank Li wrote:
> Allow pattern like "pclk" and "hclk" as clock-names.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> https://lore.kernel.org/linux-i3c/20250625200451.GA2117971-robh@kernel.org/
> ---
> Documentation/devicetree/bindings/writing-bindings.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/writing-bindings.rst b/Documentation/devicetree/bindings/writing-bindings.rst
> index 667816dd7d504..81f76ca57a394 100644
> --- a/Documentation/devicetree/bindings/writing-bindings.rst
> +++ b/Documentation/devicetree/bindings/writing-bindings.rst
> @@ -97,7 +97,8 @@ Typical cases and caveats
> constraints (e.g. list of items).
>
> - For names used in {clock,dma,interrupt,reset}-names, do not add any suffix,
> - e.g.: "tx" instead of "txirq" (for interrupt).
> + e.g.: "tx" instead of "txirq" (for interrupt). Except when only single letter
> + remains after removing the suffix, e.g., 'pclk', 'hclk'.
It's more that the examples are the hardware names for the clocks than
a single letter is too terse.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names
2025-08-26 23:55 ` Rob Herring
@ 2025-08-27 15:23 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-08-27 15:23 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Tue, Aug 26, 2025 at 06:55:19PM -0500, Rob Herring wrote:
> On Tue, Aug 26, 2025 at 11:16:49AM -0400, Frank Li wrote:
> > Allow pattern like "pclk" and "hclk" as clock-names.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > https://lore.kernel.org/linux-i3c/20250625200451.GA2117971-robh@kernel.org/
> > ---
> > Documentation/devicetree/bindings/writing-bindings.rst | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/writing-bindings.rst b/Documentation/devicetree/bindings/writing-bindings.rst
> > index 667816dd7d504..81f76ca57a394 100644
> > --- a/Documentation/devicetree/bindings/writing-bindings.rst
> > +++ b/Documentation/devicetree/bindings/writing-bindings.rst
> > @@ -97,7 +97,8 @@ Typical cases and caveats
> > constraints (e.g. list of items).
> >
> > - For names used in {clock,dma,interrupt,reset}-names, do not add any suffix,
> > - e.g.: "tx" instead of "txirq" (for interrupt).
> > + e.g.: "tx" instead of "txirq" (for interrupt). Except when only single letter
> > + remains after removing the suffix, e.g., 'pclk', 'hclk'.
>
> It's more that the examples are the hardware names for the clocks than
> a single letter is too terse.
Yes, some hardware signal use name pclk, look like [X]clk name also from
hardware. How to document it here? It breaks "do not add any suffix" and
this name is allowed.
Some hardware use quite long name like ipg-clk. just need ipg in binding.
Frank
>
> Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-27 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-26 15:16 [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names Frank Li
2025-08-26 23:55 ` Rob Herring
2025-08-27 15:23 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).