linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: [PATCH v2 1/7] mm/page_alloc: Add kernel-docs for free_pages()
Date: Tue, 26 Aug 2025 13:56:11 -0700	[thread overview]
Message-ID: <20250826205617.1032945-2-vishal.moola@gmail.com> (raw)
In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com>

Add kernel-docs to free_pages(). This will help callers understand when
to use it instead of __free_pages().

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/page_alloc.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index baead29b3e67..f5ab7d5bcbd7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5270,6 +5270,15 @@ void free_pages_nolock(struct page *page, unsigned int order)
 	___free_pages(page, order, FPI_TRYLOCK);
 }
 
+/**
+ * free_pages - Free pages allocated with __get_free_pages().
+ * @addr: The virtual address tied to a page returned from __get_free_pages().
+ * @order: The order of the allocation.
+ *
+ * This function behaves the same as __free_pages(). Use this function
+ * to free pages when you only have a valid virtual address. If you have
+ * the page, call __free_pages() instead.
+ */
 void free_pages(unsigned long addr, unsigned int order)
 {
 	if (addr != 0) {
-- 
2.51.0


  reply	other threads:[~2025-08-26 20:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 20:56 [PATCH v2 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-08-26 20:56 ` Vishal Moola (Oracle) [this message]
2025-08-27 17:18   ` [PATCH v2 1/7] mm/page_alloc: Add kernel-docs for free_pages() SeongJae Park
2025-08-26 20:56 ` [PATCH v2 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-08-26 20:56 ` [PATCH v2 3/7] x86: Stop calling page_address() in free_pages() Vishal Moola (Oracle)
2025-08-26 21:08   ` Dave Hansen
2025-08-26 20:56 ` [PATCH v2 4/7] riscv: " Vishal Moola (Oracle)
2025-08-26 20:56 ` [PATCH v2 5/7] powerpc: " Vishal Moola (Oracle)
2025-09-01  3:47   ` Ritesh Harjani
2025-08-26 20:56 ` [PATCH v2 6/7] arm64: " Vishal Moola (Oracle)
2025-08-27 14:08   ` Catalin Marinas
2025-08-26 20:56 ` [PATCH v2 7/7] virtio_balloon: " Vishal Moola (Oracle)
2025-08-27 12:01   ` David Hildenbrand
2025-08-27 18:29     ` Vishal Moola (Oracle)
2025-08-28 14:53       ` Matthew Wilcox
2025-08-30 11:48         ` Michael S. Tsirkin
2025-09-02 13:19           ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250826205617.1032945-2-vishal.moola@gmail.com \
    --to=vishal.moola@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).