linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v2 3/7] x86: Stop calling page_address() in free_pages()
Date: Tue, 26 Aug 2025 13:56:13 -0700	[thread overview]
Message-ID: <20250826205617.1032945-4-vishal.moola@gmail.com> (raw)
In-Reply-To: <20250826205617.1032945-1-vishal.moola@gmail.com>

free_pages() should be used when we only have a virtual address. We
should call __free_pages() directly on our page instead.

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
 arch/x86/mm/init_64.c          | 2 +-
 arch/x86/platform/efi/memmap.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index b9426fce5f3e..0e4270e20fad 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1031,7 +1031,7 @@ static void __meminit free_pagetable(struct page *page, int order)
 		free_reserved_pages(page, nr_pages);
 #endif
 	} else {
-		free_pages((unsigned long)page_address(page), order);
+		__free_pages(page, order);
 	}
 }
 
diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c
index 061b8ecc71a1..023697c88910 100644
--- a/arch/x86/platform/efi/memmap.c
+++ b/arch/x86/platform/efi/memmap.c
@@ -42,7 +42,7 @@ void __init __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
 		struct page *p = pfn_to_page(PHYS_PFN(phys));
 		unsigned int order = get_order(size);
 
-		free_pages((unsigned long) page_address(p), order);
+		__free_pages(p, order);
 	}
 }
 
-- 
2.51.0


  parent reply	other threads:[~2025-08-26 20:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 20:56 [PATCH v2 0/7] Cleanup free_pages() misuse Vishal Moola (Oracle)
2025-08-26 20:56 ` [PATCH v2 1/7] mm/page_alloc: Add kernel-docs for free_pages() Vishal Moola (Oracle)
2025-08-27 17:18   ` SeongJae Park
2025-08-26 20:56 ` [PATCH v2 2/7] aoe: Stop calling page_address() in free_page() Vishal Moola (Oracle)
2025-08-26 20:56 ` Vishal Moola (Oracle) [this message]
2025-08-26 21:08   ` [PATCH v2 3/7] x86: Stop calling page_address() in free_pages() Dave Hansen
2025-08-26 20:56 ` [PATCH v2 4/7] riscv: " Vishal Moola (Oracle)
2025-08-26 20:56 ` [PATCH v2 5/7] powerpc: " Vishal Moola (Oracle)
2025-09-01  3:47   ` Ritesh Harjani
2025-08-26 20:56 ` [PATCH v2 6/7] arm64: " Vishal Moola (Oracle)
2025-08-27 14:08   ` Catalin Marinas
2025-08-26 20:56 ` [PATCH v2 7/7] virtio_balloon: " Vishal Moola (Oracle)
2025-08-27 12:01   ` David Hildenbrand
2025-08-27 18:29     ` Vishal Moola (Oracle)
2025-08-28 14:53       ` Matthew Wilcox
2025-08-30 11:48         ` Michael S. Tsirkin
2025-09-02 13:19           ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250826205617.1032945-4-vishal.moola@gmail.com \
    --to=vishal.moola@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).