From: Rosen Penev <rosenp@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
linux-mips@vger.kernel.org (open list:MIPS)
Subject: [PATCHv4 3/3] mips: qca: specify WMAC LED directly
Date: Tue, 26 Aug 2025 17:56:58 -0700 [thread overview]
Message-ID: <20250827005658.3464-4-rosenp@gmail.com> (raw)
In-Reply-To: <20250827005658.3464-1-rosenp@gmail.com>
The ath9k driver creates an LED unconditionally being driven with
sometimes the wrong pin. Not only that, the current dts definitions have
LEDs for the WMAC that do not behave in response to it. Fix both issues.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 9 ++++-----
arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts | 11 +++++------
arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts | 11 +++++------
3 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index a7901bb040ce..0e813c38c31c 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -56,11 +56,6 @@ led-2 {
label = "tp-link:green:qss";
gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
};
-
- led-3 {
- label = "tp-link:green:wlan";
- gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
- };
};
};
@@ -111,4 +106,8 @@ partition@2 {
&wifi {
status = "okay";
+
+ led {
+ reg = <9>;
+ };
};
diff --git a/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts b/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
index 37a74aabe4b4..19d72a0fdd8d 100644
--- a/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
+++ b/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
@@ -22,12 +22,6 @@ memory@0 {
leds {
compatible = "gpio-leds";
- led-wlan {
- label = "dragino2:red:wlan";
- gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
- default-state = "off";
- };
-
led-lan {
label = "dragino2:red:lan";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
@@ -101,4 +95,9 @@ spiflash: w25q128@0 {
&wifi {
status = "okay";
+
+ led {
+ reg = <0>;
+ led-active-high;
+ };
};
diff --git a/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts b/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
index a7108c803eb3..c12dd4a72772 100644
--- a/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
+++ b/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
@@ -22,12 +22,6 @@ memory@0 {
leds {
compatible = "gpio-leds";
- led-wlan {
- label = "tp-link:green:wlan";
- gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
- default-state = "off";
- };
-
led-lan {
label = "tp-link:green:lan";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
@@ -117,4 +111,9 @@ spiflash: s25sl032p@0 {
&wifi {
status = "okay";
+
+ led {
+ reg = <0>;
+ led-active-high;
+ };
};
--
2.50.1
prev parent reply other threads:[~2025-08-27 0:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 0:56 [PATCHv4 0/3] wifi: ath9k: ahb: add OF LED support Rosen Penev
2025-08-27 0:56 ` [PATCHv4 1/3] dt-bindings: net: wireless: ath9k: add led bindings Rosen Penev
2025-08-28 13:30 ` Rob Herring (Arm)
2025-08-29 1:47 ` Rosen Penev
2025-08-29 6:02 ` Krzysztof Kozlowski
2025-08-29 6:12 ` Rosen Penev
2025-08-29 6:30 ` Krzysztof Kozlowski
2025-08-27 0:56 ` [PATCHv4 2/3] wifi: ath9k: ahb: add led pin OF support Rosen Penev
2025-08-27 0:56 ` Rosen Penev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827005658.3464-4-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
--cc=toke@toke.dk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).