From: Yu Kuai <yukuai1@huaweicloud.com>
To: axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com,
song@kernel.org, neil@brown.name, akpm@linux-foundation.org,
hch@infradead.org, colyli@kernel.org, hare@suse.de,
tieren@fnnas.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-raid@vger.kernel.org,
yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com,
yangerkun@huawei.com, johnny.chenyi@huawei.com
Subject: [PATCH RFC v2 10/10] md/raid0: convert raid0_make_request() to use bio_submit_split_bioset()
Date: Thu, 28 Aug 2025 14:57:33 +0800 [thread overview]
Message-ID: <20250828065733.556341-11-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20250828065733.556341-1-yukuai1@huaweicloud.com>
From: Yu Kuai <yukuai3@huawei.com>
Currently, raid0_make_request() will remap the original bio to underlying
disks to prevent disordered IO. Now that bio_submit_split_bioset() will put
original bio to the head of current->bio_list, it's safe converting to use
this helper and bio will still be ordered.
On the one hand unify bio split code; On the other hand fix missing
blkcg_bio_issue_init() and trace_block_split() for split IO.
CC: Jan Kara <jack@suse.cz>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/md/raid0.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index 4dcc5133d679..8773f633299e 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -607,17 +607,9 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio)
: sector_div(sector, chunk_sects));
if (sectors < bio_sectors(bio)) {
- struct bio *split = bio_split(bio, sectors, GFP_NOIO,
- &mddev->bio_set);
-
- if (IS_ERR(split)) {
- bio->bi_status = errno_to_blk_status(PTR_ERR(split));
- bio_endio(bio);
+ bio = bio_submit_split_bioset(bio, sectors, &mddev->bio_set);
+ if (!bio)
return true;
- }
- bio_chain(split, bio);
- raid0_map_submit_bio(mddev, bio);
- bio = split;
}
raid0_map_submit_bio(mddev, bio);
--
2.39.2
prev parent reply other threads:[~2025-08-28 7:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 6:57 [PATCH RFC v2 00/10] block: fix disordered IO in the case recursive split Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 01/10] block: factor out a helper bio_submit_split_bioset() Yu Kuai
2025-08-30 0:37 ` Damien Le Moal
2025-08-30 4:03 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 02/10] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset() Yu Kuai
2025-08-30 0:41 ` Damien Le Moal
2025-08-30 4:10 ` Yu Kuai
2025-08-30 4:38 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 03/10] md/raid1: convert " Yu Kuai
2025-08-30 0:43 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 04/10] md/raid10: convert read/write " Yu Kuai
2025-08-30 0:48 ` Damien Le Moal
2025-08-30 4:18 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 05/10] md/raid5: convert " Yu Kuai
2025-08-30 0:50 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 06/10] md/md-linear: " Yu Kuai
2025-08-30 0:51 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 07/10] blk-crypto: " Yu Kuai
2025-08-30 0:55 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 08/10] block: skip unnecessary checks for split bio Yu Kuai
2025-08-30 0:58 ` Damien Le Moal
2025-08-30 4:22 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 09/10] block: fix disordered IO in the case recursive split Yu Kuai
2025-08-30 1:02 ` Damien Le Moal
2025-08-30 4:28 ` Yu Kuai
2025-09-01 2:40 ` Yu Kuai
2025-09-01 6:51 ` Damien Le Moal
2025-08-28 6:57 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828065733.556341-11-yukuai1@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@kernel.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=song@kernel.org \
--cc=tieren@fnnas.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).