linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jinchao Wang <wangjinchao600@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	"Naveen N . Rao" <naveen@kernel.org>,
	linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jinchao Wang <wangjinchao600@gmail.com>
Subject: [PATCH 04/17] mm/ksw: add HWBP pre-allocation support
Date: Thu, 28 Aug 2025 15:32:37 +0800	[thread overview]
Message-ID: <20250828073311.1116593-5-wangjinchao600@gmail.com> (raw)
In-Reply-To: <20250828073311.1116593-1-wangjinchao600@gmail.com>

Pre-allocate per-CPU hardware breakpoints at init with a dummy address,
which will be retargeted dynamically in kprobe handler. This avoids
allocation in atomic contexts.

Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
---
 mm/kstackwatch/kstackwatch.h |  6 ++++
 mm/kstackwatch/watch.c       | 62 ++++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)

diff --git a/mm/kstackwatch/kstackwatch.h b/mm/kstackwatch/kstackwatch.h
index b5f1835586c1..2318779bde70 100644
--- a/mm/kstackwatch/kstackwatch.h
+++ b/mm/kstackwatch/kstackwatch.h
@@ -36,4 +36,10 @@ struct ksw_config {
 	char config_str[MAX_CONFIG_STR_LEN];
 };
 
+extern bool panic_on_catch;
+
+/* watch management */
+int ksw_watch_init(struct ksw_config *config);
+void ksw_watch_exit(void);
+
 #endif /* _KSTACKWATCH_H */
diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c
index cec594032515..e7ed88700b49 100644
--- a/mm/kstackwatch/watch.c
+++ b/mm/kstackwatch/watch.c
@@ -1 +1,63 @@
 // SPDX-License-Identifier: GPL-2.0
+
+#include <linux/hw_breakpoint.h>
+#include <linux/kern_levels.h>
+#include <linux/kprobes.h>
+#include <linux/printk.h>
+#include <linux/perf_event.h>
+#include <linux/sched/debug.h>
+#include <linux/slab.h>
+#include <linux/smp.h>
+#include <linux/stacktrace.h>
+
+#include "kstackwatch.h"
+
+#define MAX_STACK_ENTRIES 64
+
+struct perf_event *__percpu *watch_events;
+struct ksw_config *watch_config;
+
+static unsigned long long watch_holder;
+
+static void ksw_watch_handler(struct perf_event *bp,
+			      struct perf_sample_data *data,
+			      struct pt_regs *regs)
+{
+	pr_err("========== KStackWatch: Caught stack corruption =======\n");
+	pr_err("KSW: config %s\n", watch_config->config_str);
+	show_regs(regs);
+	pr_err("=================== KStackWatch End ==================\n");
+
+	if (panic_on_catch)
+		panic("KSW: Stack corruption detected");
+}
+
+int ksw_watch_init(struct ksw_config *config)
+{
+	struct perf_event_attr attr;
+
+	hw_breakpoint_init(&attr);
+	attr.bp_addr = (unsigned long)&watch_holder;
+	attr.bp_len = HW_BREAKPOINT_LEN_8;
+	attr.bp_type = HW_BREAKPOINT_W;
+	watch_events =
+		register_wide_hw_breakpoint(&attr, ksw_watch_handler, NULL);
+	if (IS_ERR((void *)watch_events)) {
+		int ret = PTR_ERR((void *)watch_events);
+
+		pr_err("KSW: failed to register wide hw breakpoint: %d\n", ret);
+		return ret;
+	}
+
+	watch_config = config;
+	pr_info("KSW: watch inited\n");
+	return 0;
+}
+
+void ksw_watch_exit(void)
+{
+	unregister_wide_hw_breakpoint(watch_events);
+	watch_events = NULL;
+
+	pr_info("KSW: watch exited\n");
+}
-- 
2.43.0


  parent reply	other threads:[~2025-08-28  7:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  7:32 [PATCH 00/17] mm/ksw: Introduce real-time Kernel Stack Watch debugging tool Jinchao Wang
2025-08-28  7:32 ` [PATCH 01/17] mm/ksw: add build system support Jinchao Wang
2025-08-28  7:32 ` [PATCH 02/17] mm/ksw: add ksw_config struct and parser Jinchao Wang
2025-08-28  7:32 ` [PATCH 03/17] mm/ksw: add /proc/kstackwatch interface Jinchao Wang
2025-08-28  7:32 ` Jinchao Wang [this message]
2025-08-28  7:32 ` [PATCH 05/17] x86/HWBP: introduce arch_reinstall_hw_breakpoint() for atomic context Jinchao Wang
2025-08-28  7:32 ` [PATCH 06/17] mm/ksw: add atomic watch on/off operations Jinchao Wang
2025-08-28  7:32 ` [PATCH 07/17] mm/ksw: add stack probe support Jinchao Wang
2025-08-28  7:32 ` [PATCH 08/17] mm/ksw: implement stack canary and local var resolution logic Jinchao Wang
2025-08-28  7:32 ` [PATCH 09/17] mm/ksw: add per-task recursion depth tracking Jinchao Wang
2025-08-28  7:32 ` [PATCH 10/17] mm/ksw: coordinate watch and stack for full functionality Jinchao Wang
2025-08-28  7:32 ` [PATCH 11/17] mm/ksw: add self-debug functions for kstackwatch watch Jinchao Wang
2025-08-28  7:32 ` [PATCH 12/17] mm/ksw: add test module Jinchao Wang
2025-08-28  7:32 ` [PATCH 13/17] mm/ksw: add stack overflow test Jinchao Wang
2025-08-28  7:32 ` [PATCH 14/17] mm/ksw: add simplified silent corruption test Jinchao Wang
2025-08-28  7:32 ` [PATCH 15/17] mm/ksw: add recursive " Jinchao Wang
2025-08-28  7:32 ` [PATCH 16/17] tools/kstackwatch: add interactive test script for KStackWatch Jinchao Wang
2025-08-28  7:32 ` [PATCH 17/17] MAINTAINERS: add entry for KStackWatch (Kernel Stack Watch) Jinchao Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828073311.1116593-5-wangjinchao600@gmail.com \
    --to=wangjinchao600@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=naveen@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).