From: Steven Rostedt <rostedt@goodmis.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Luo Gengkun <luogengkun@huaweicloud.com>,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] tracing: Fix tracing_marker may trigger page fault during preempt_disable
Date: Fri, 29 Aug 2025 18:13:11 -0400 [thread overview]
Message-ID: <20250829181311.079f33bf@gandalf.local.home> (raw)
In-Reply-To: <aLIFRHcsEo2e2GE7@arm.com>
On Fri, 29 Aug 2025 20:53:40 +0100
Catalin Marinas <catalin.marinas@arm.com> wrote:
valid user address.
>
> BTW, arm64 also bails out early in do_page_fault() if in_atomic() but I
> suspect that's not the case here.
>
> Adding Al Viro since since he wrote a large part of uaccess.h.
>
So, __copy_from_user_inatomic() is supposed to be called if
pagefault_disable() has already been called? If this is the case, can we
add more comments to this code? I've been using the inatomic() version this
way in preempt disabled locations since 2016.
Looks like it needs to be converted to copy_from_user_nofault().
Luo, this version of the patch looks legit, no need for a v2.
I just wanted to figure out why __copy_from_user_inatomic() wasn't atomic.
If anything, it needs to be better documented.
-- Steve
next prev parent reply other threads:[~2025-08-29 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 10:51 [PATCH] tracing: Fix tracing_marker may trigger page fault during preempt_disable Luo Gengkun
2025-08-19 17:50 ` Steven Rostedt
2025-08-29 8:29 ` Luo Gengkun
2025-08-29 12:26 ` Steven Rostedt
2025-08-29 12:36 ` Steven Rostedt
2025-08-29 19:53 ` Catalin Marinas
2025-08-29 22:13 ` Steven Rostedt [this message]
2025-08-30 10:22 ` Catalin Marinas
2025-09-01 9:56 ` Mark Rutland
2025-09-01 12:28 ` Catalin Marinas
2025-09-01 13:07 ` Mark Rutland
2025-09-01 9:43 ` Mark Rutland
2025-09-02 14:11 ` Steven Rostedt
2025-09-01 16:01 ` Masami Hiramatsu
2025-09-01 15:56 ` Masami Hiramatsu
2025-09-02 3:47 ` Luo Gengkun
2025-09-02 7:35 ` Masami Hiramatsu
2025-09-02 14:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829181311.079f33bf@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luogengkun@huaweicloud.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).