* [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410
@ 2025-08-30 11:09 Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 1/5] iio: adc: exynos_adc: Drop S3C2410 support Krzysztof Kozlowski
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
S3C2410 is gone from kernel, so we can drop its support and remaining
related pieces.
Best regards,
Krzysztof
---
Krzysztof Kozlowski (5):
iio: adc: exynos_adc: Drop S3C2410 support
iio: adc: exynos_adc: Drop touchscreen support
iio: adc: exynos_adc: Drop platform data support
dt-bindings: iio: adc: samsung,exynos: Drop S3C2410
dt-bindings: iio: adc: samsung,exynos: Drop touchscreen support
.../bindings/iio/adc/samsung,exynos-adc.yaml | 23 +-
drivers/iio/adc/exynos_adc.c | 280 +--------------------
2 files changed, 4 insertions(+), 299 deletions(-)
---
base-commit: 3cace99d63192a7250461b058279a42d91075d0c
change-id: 20250830-s3c-cleanup-adc-71ac80978520
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/5] iio: adc: exynos_adc: Drop S3C2410 support
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
@ 2025-08-30 11:09 ` Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
Samsung S3C24xx family of SoCs was removed from the Linux kernel in the
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
2023. There are no in-kernel users of its compatibles.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/iio/adc/exynos_adc.c | 75 +-------------------------------------------
1 file changed, 1 insertion(+), 74 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 4614cf848535944a41e0ab19f35c5ca0546000c0..17fd33c6bd6d0dcf41771331ecb328e58d820ed0 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -44,9 +44,6 @@
#define ADC_V1_MUX(x) ((x) + 0x1c)
#define ADC_V1_CLRINTPNDNUP(x) ((x) + 0x20)
-/* S3C2410 ADC registers definitions */
-#define ADC_S3C2410_MUX(x) ((x) + 0x18)
-
/* Future ADC_V2 registers definitions */
#define ADC_V2_CON1(x) ((x) + 0x00)
#define ADC_V2_CON2(x) ((x) + 0x04)
@@ -61,10 +58,8 @@
#define ADC_V1_CON_PRSCLV(x) (((x) & 0xFF) << 6)
#define ADC_V1_CON_STANDBY (1u << 2)
-/* Bit definitions for S3C2410 ADC */
+/* Bit definitions for S3C2410 / S3C6410 ADC */
#define ADC_S3C2410_CON_SELMUX(x) (((x) & 7) << 3)
-#define ADC_S3C2410_DATX_MASK 0x3FF
-#define ADC_S3C2416_CON_RES_SEL (1u << 3)
/* touch screen always uses channel 0 */
#define ADC_S3C2410_MUX_TS 0
@@ -307,53 +302,6 @@ static const struct exynos_adc_data exynos_adc_s5pv210_data = {
.start_conv = exynos_adc_v1_start_conv,
};
-static void exynos_adc_s3c2416_start_conv(struct exynos_adc *info,
- unsigned long addr)
-{
- u32 con1;
-
- /* Enable 12 bit ADC resolution */
- con1 = readl(ADC_V1_CON(info->regs));
- con1 |= ADC_S3C2416_CON_RES_SEL;
- writel(con1, ADC_V1_CON(info->regs));
-
- /* Select channel for S3C2416 */
- writel(addr, ADC_S3C2410_MUX(info->regs));
-
- con1 = readl(ADC_V1_CON(info->regs));
- writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs));
-}
-
-static struct exynos_adc_data const exynos_adc_s3c2416_data = {
- .num_channels = MAX_ADC_V1_CHANNELS,
- .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */
-
- .init_hw = exynos_adc_v1_init_hw,
- .exit_hw = exynos_adc_v1_exit_hw,
- .start_conv = exynos_adc_s3c2416_start_conv,
-};
-
-static void exynos_adc_s3c2443_start_conv(struct exynos_adc *info,
- unsigned long addr)
-{
- u32 con1;
-
- /* Select channel for S3C2433 */
- writel(addr, ADC_S3C2410_MUX(info->regs));
-
- con1 = readl(ADC_V1_CON(info->regs));
- writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs));
-}
-
-static struct exynos_adc_data const exynos_adc_s3c2443_data = {
- .num_channels = MAX_ADC_V1_CHANNELS,
- .mask = ADC_S3C2410_DATX_MASK, /* 10 bit ADC resolution */
-
- .init_hw = exynos_adc_v1_init_hw,
- .exit_hw = exynos_adc_v1_exit_hw,
- .start_conv = exynos_adc_s3c2443_start_conv,
-};
-
static void exynos_adc_s3c64xx_start_conv(struct exynos_adc *info,
unsigned long addr)
{
@@ -365,15 +313,6 @@ static void exynos_adc_s3c64xx_start_conv(struct exynos_adc *info,
writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs));
}
-static struct exynos_adc_data const exynos_adc_s3c24xx_data = {
- .num_channels = MAX_ADC_V1_CHANNELS,
- .mask = ADC_S3C2410_DATX_MASK, /* 10 bit ADC resolution */
-
- .init_hw = exynos_adc_v1_init_hw,
- .exit_hw = exynos_adc_v1_exit_hw,
- .start_conv = exynos_adc_s3c64xx_start_conv,
-};
-
static struct exynos_adc_data const exynos_adc_s3c64xx_data = {
.num_channels = MAX_ADC_V1_CHANNELS,
.mask = ADC_DATX_MASK, /* 12 bit ADC resolution */
@@ -486,18 +425,6 @@ static const struct exynos_adc_data exynos7_adc_data = {
static const struct of_device_id exynos_adc_match[] = {
{
- .compatible = "samsung,s3c2410-adc",
- .data = &exynos_adc_s3c24xx_data,
- }, {
- .compatible = "samsung,s3c2416-adc",
- .data = &exynos_adc_s3c2416_data,
- }, {
- .compatible = "samsung,s3c2440-adc",
- .data = &exynos_adc_s3c24xx_data,
- }, {
- .compatible = "samsung,s3c2443-adc",
- .data = &exynos_adc_s3c2443_data,
- }, {
.compatible = "samsung,s3c6410-adc",
.data = &exynos_adc_s3c64xx_data,
}, {
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 1/5] iio: adc: exynos_adc: Drop S3C2410 support Krzysztof Kozlowski
@ 2025-08-30 11:09 ` Krzysztof Kozlowski
2025-08-30 13:09 ` Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 3/5] iio: adc: exynos_adc: Drop platform data support Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
With last user of touchscreen via ADC (S3C24xx SoC) gone, drop the
remaining code from Samsung SoC ADC driver.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/iio/adc/exynos_adc.c | 196 +------------------------------------------
1 file changed, 1 insertion(+), 195 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 17fd33c6bd6d0dcf41771331ecb328e58d820ed0..30f6d8436e775a8d2177951b436cd45152307ea2 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -19,11 +19,9 @@
#include <linux/clk.h>
#include <linux/completion.h>
#include <linux/of.h>
-#include <linux/of_irq.h>
#include <linux/regulator/consumer.h>
#include <linux/of_platform.h>
#include <linux/err.h>
-#include <linux/input.h>
#include <linux/iio/iio.h>
#include <linux/iio/machine.h>
@@ -35,14 +33,12 @@
/* S3C/EXYNOS4412/5250 ADC_V1 registers definitions */
#define ADC_V1_CON(x) ((x) + 0x00)
-#define ADC_V1_TSC(x) ((x) + 0x04)
#define ADC_V1_DLY(x) ((x) + 0x08)
#define ADC_V1_DATX(x) ((x) + 0x0C)
#define ADC_V1_DATY(x) ((x) + 0x10)
#define ADC_V1_UPDN(x) ((x) + 0x14)
#define ADC_V1_INTCLR(x) ((x) + 0x18)
#define ADC_V1_MUX(x) ((x) + 0x1c)
-#define ADC_V1_CLRINTPNDNUP(x) ((x) + 0x20)
/* Future ADC_V2 registers definitions */
#define ADC_V2_CON1(x) ((x) + 0x00)
@@ -61,17 +57,12 @@
/* Bit definitions for S3C2410 / S3C6410 ADC */
#define ADC_S3C2410_CON_SELMUX(x) (((x) & 7) << 3)
-/* touch screen always uses channel 0 */
-#define ADC_S3C2410_MUX_TS 0
-
/* ADCTSC Register Bits */
#define ADC_S3C2443_TSC_UD_SEN (1u << 8)
#define ADC_S3C2410_TSC_YM_SEN (1u << 7)
#define ADC_S3C2410_TSC_YP_SEN (1u << 6)
#define ADC_S3C2410_TSC_XM_SEN (1u << 5)
#define ADC_S3C2410_TSC_XP_SEN (1u << 4)
-#define ADC_S3C2410_TSC_PULL_UP_DISABLE (1u << 3)
-#define ADC_S3C2410_TSC_AUTO_PST (1u << 2)
#define ADC_S3C2410_TSC_XY_PST(x) (((x) & 0x3) << 0)
#define ADC_TSC_WAIT4INT (ADC_S3C2410_TSC_YM_SEN | \
@@ -79,12 +70,6 @@
ADC_S3C2410_TSC_XP_SEN | \
ADC_S3C2410_TSC_XY_PST(3))
-#define ADC_TSC_AUTOPST (ADC_S3C2410_TSC_YM_SEN | \
- ADC_S3C2410_TSC_YP_SEN | \
- ADC_S3C2410_TSC_XP_SEN | \
- ADC_S3C2410_TSC_AUTO_PST | \
- ADC_S3C2410_TSC_XY_PST(0))
-
/* Bit definitions for ADC_V2 */
#define ADC_V2_CON1_SOFT_RESET (1u << 2)
@@ -116,13 +101,11 @@
struct exynos_adc {
struct exynos_adc_data *data;
struct device *dev;
- struct input_dev *input;
void __iomem *regs;
struct regmap *pmu_map;
struct clk *clk;
struct clk *sclk;
unsigned int irq;
- unsigned int tsirq;
unsigned int delay;
struct regulator *vdd;
@@ -131,12 +114,6 @@ struct exynos_adc {
u32 value;
unsigned int version;
- bool ts_enabled;
-
- bool read_ts;
- u32 ts_x;
- u32 ts_y;
-
/*
* Lock to protect from potential concurrent access to the
* completion callback during a manual conversion. For this driver
@@ -507,55 +484,13 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
return ret;
}
-static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
-{
- struct exynos_adc *info = iio_priv(indio_dev);
- unsigned long time_left;
- int ret;
-
- mutex_lock(&info->lock);
- info->read_ts = true;
-
- reinit_completion(&info->completion);
-
- writel(ADC_S3C2410_TSC_PULL_UP_DISABLE | ADC_TSC_AUTOPST,
- ADC_V1_TSC(info->regs));
-
- /* Select the ts channel to be used and Trigger conversion */
- info->data->start_conv(info, ADC_S3C2410_MUX_TS);
-
- time_left = wait_for_completion_timeout(&info->completion,
- EXYNOS_ADC_TIMEOUT);
- if (time_left == 0) {
- dev_warn(&indio_dev->dev, "Conversion timed out! Resetting\n");
- if (info->data->init_hw)
- info->data->init_hw(info);
- ret = -ETIMEDOUT;
- } else {
- *x = info->ts_x;
- *y = info->ts_y;
- ret = 0;
- }
-
- info->read_ts = false;
- mutex_unlock(&info->lock);
-
- return ret;
-}
-
static irqreturn_t exynos_adc_isr(int irq, void *dev_id)
{
struct exynos_adc *info = dev_id;
u32 mask = info->data->mask;
/* Read value */
- if (info->read_ts) {
- info->ts_x = readl(ADC_V1_DATX(info->regs));
- info->ts_y = readl(ADC_V1_DATY(info->regs));
- writel(ADC_TSC_WAIT4INT | ADC_S3C2443_TSC_UD_SEN, ADC_V1_TSC(info->regs));
- } else {
- info->value = readl(ADC_V1_DATX(info->regs)) & mask;
- }
+ info->value = readl(ADC_V1_DATX(info->regs)) & mask;
/* clear irq */
if (info->data->clear_irq)
@@ -566,46 +501,6 @@ static irqreturn_t exynos_adc_isr(int irq, void *dev_id)
return IRQ_HANDLED;
}
-/*
- * Here we (ab)use a threaded interrupt handler to stay running
- * for as long as the touchscreen remains pressed, we report
- * a new event with the latest data and then sleep until the
- * next timer tick. This mirrors the behavior of the old
- * driver, with much less code.
- */
-static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
-{
- struct exynos_adc *info = dev_id;
- struct iio_dev *dev = dev_get_drvdata(info->dev);
- u32 x, y;
- bool pressed;
- int ret;
-
- while (READ_ONCE(info->ts_enabled)) {
- ret = exynos_read_s3c64xx_ts(dev, &x, &y);
- if (ret == -ETIMEDOUT)
- break;
-
- pressed = x & y & ADC_DATX_PRESSED;
- if (!pressed) {
- input_report_key(info->input, BTN_TOUCH, 0);
- input_sync(info->input);
- break;
- }
-
- input_report_abs(info->input, ABS_X, x & ADC_DATX_MASK);
- input_report_abs(info->input, ABS_Y, y & ADC_DATY_MASK);
- input_report_key(info->input, BTN_TOUCH, 1);
- input_sync(info->input);
-
- usleep_range(1000, 1100);
- }
-
- writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
-
- return IRQ_HANDLED;
-}
-
static int exynos_adc_reg_access(struct iio_dev *indio_dev,
unsigned reg, unsigned writeval,
unsigned *readval)
@@ -657,70 +552,12 @@ static int exynos_adc_remove_devices(struct device *dev, void *c)
return 0;
}
-static int exynos_adc_ts_open(struct input_dev *dev)
-{
- struct exynos_adc *info = input_get_drvdata(dev);
-
- WRITE_ONCE(info->ts_enabled, true);
- enable_irq(info->tsirq);
-
- return 0;
-}
-
-static void exynos_adc_ts_close(struct input_dev *dev)
-{
- struct exynos_adc *info = input_get_drvdata(dev);
-
- WRITE_ONCE(info->ts_enabled, false);
- disable_irq(info->tsirq);
-}
-
-static int exynos_adc_ts_init(struct exynos_adc *info)
-{
- int ret;
-
- if (info->tsirq <= 0)
- return -ENODEV;
-
- info->input = input_allocate_device();
- if (!info->input)
- return -ENOMEM;
-
- info->input->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
- info->input->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
-
- input_set_abs_params(info->input, ABS_X, 0, 0x3FF, 0, 0);
- input_set_abs_params(info->input, ABS_Y, 0, 0x3FF, 0, 0);
-
- info->input->name = "S3C24xx TouchScreen";
- info->input->id.bustype = BUS_HOST;
- info->input->open = exynos_adc_ts_open;
- info->input->close = exynos_adc_ts_close;
-
- input_set_drvdata(info->input, info);
-
- ret = input_register_device(info->input);
- if (ret) {
- input_free_device(info->input);
- return ret;
- }
-
- ret = request_threaded_irq(info->tsirq, NULL, exynos_ts_isr,
- IRQF_ONESHOT | IRQF_NO_AUTOEN,
- "touchscreen", info);
- if (ret)
- input_unregister_device(info->input);
-
- return ret;
-}
-
static int exynos_adc_probe(struct platform_device *pdev)
{
struct exynos_adc *info = NULL;
struct device_node *np = pdev->dev.of_node;
struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = NULL;
- bool has_ts = false;
int ret;
int irq;
@@ -753,27 +590,10 @@ static int exynos_adc_probe(struct platform_device *pdev)
}
}
- /* leave out any TS related code if unreachable */
- if (IS_REACHABLE(CONFIG_INPUT)) {
- has_ts = of_property_read_bool(pdev->dev.of_node,
- "has-touchscreen") || pdata;
- }
-
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
info->irq = irq;
-
- if (has_ts) {
- irq = platform_get_irq(pdev, 1);
- if (irq == -EPROBE_DEFER)
- return irq;
-
- info->tsirq = irq;
- } else {
- info->tsirq = -1;
- }
-
info->dev = &pdev->dev;
init_completion(&info->completion);
@@ -842,11 +662,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
else
info->delay = 10000;
- if (has_ts)
- ret = exynos_adc_ts_init(info);
- if (ret)
- goto err_iio;
-
ret = of_platform_populate(np, exynos_adc_match, NULL, &indio_dev->dev);
if (ret < 0) {
dev_err(&pdev->dev, "failed adding child nodes\n");
@@ -858,11 +673,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
err_of_populate:
device_for_each_child(&indio_dev->dev, NULL,
exynos_adc_remove_devices);
- if (has_ts) {
- input_unregister_device(info->input);
- free_irq(info->tsirq, info);
- }
-err_iio:
iio_device_unregister(indio_dev);
err_irq:
free_irq(info->irq, info);
@@ -882,10 +692,6 @@ static void exynos_adc_remove(struct platform_device *pdev)
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
struct exynos_adc *info = iio_priv(indio_dev);
- if (IS_REACHABLE(CONFIG_INPUT) && info->input) {
- free_irq(info->tsirq, info);
- input_unregister_device(info->input);
- }
device_for_each_child(&indio_dev->dev, NULL,
exynos_adc_remove_devices);
iio_device_unregister(indio_dev);
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/5] iio: adc: exynos_adc: Drop platform data support
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 1/5] iio: adc: exynos_adc: Drop S3C2410 support Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support Krzysztof Kozlowski
@ 2025-08-30 11:09 ` Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 4/5] dt-bindings: iio: adc: samsung,exynos: Drop S3C2410 Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
There are no Samsung Exynos SoC ADC driver users which bind via platform
ID, thus platform data is never set and can be dropped.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/iio/adc/exynos_adc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 30f6d8436e775a8d2177951b436cd45152307ea2..dd1494ee365a7b34d6b485ee4c9e753f50b5ff26 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -106,7 +106,6 @@ struct exynos_adc {
struct clk *clk;
struct clk *sclk;
unsigned int irq;
- unsigned int delay;
struct regulator *vdd;
struct completion completion;
@@ -213,7 +212,7 @@ static void exynos_adc_v1_init_hw(struct exynos_adc *info)
writel(con1, ADC_V1_CON(info->regs));
/* set touchscreen delay */
- writel(info->delay, ADC_V1_DLY(info->regs));
+ writel(10000, ADC_V1_DLY(info->regs));
}
static void exynos_adc_v1_exit_hw(struct exynos_adc *info)
@@ -556,7 +555,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
{
struct exynos_adc *info = NULL;
struct device_node *np = pdev->dev.of_node;
- struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = NULL;
int ret;
int irq;
@@ -657,11 +655,6 @@ static int exynos_adc_probe(struct platform_device *pdev)
if (info->data->init_hw)
info->data->init_hw(info);
- if (pdata)
- info->delay = pdata->delay;
- else
- info->delay = 10000;
-
ret = of_platform_populate(np, exynos_adc_match, NULL, &indio_dev->dev);
if (ret < 0) {
dev_err(&pdev->dev, "failed adding child nodes\n");
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/5] dt-bindings: iio: adc: samsung,exynos: Drop S3C2410
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-08-30 11:09 ` [PATCH 3/5] iio: adc: exynos_adc: Drop platform data support Krzysztof Kozlowski
@ 2025-08-30 11:09 ` Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 5/5] dt-bindings: iio: adc: samsung,exynos: Drop touchscreen support Krzysztof Kozlowski
2025-08-30 12:27 ` [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Andy Shevchenko
5 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
Samsung S3C24xx family of SoCs was removed the Linux kernel in the
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
2023. There are no in-kernel users of remaining S3C24xx compatibles.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 8069e99ddac860b22c793c3ef9479f720cfd8c65..73d7ba0fda1def433a97d10bce21e762a307e36c 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -18,10 +18,6 @@ properties:
- samsung,exynos3250-adc
- samsung,exynos4212-adc # Exynos4212 and Exynos4412
- samsung,exynos7-adc
- - samsung,s3c2410-adc
- - samsung,s3c2416-adc
- - samsung,s3c2440-adc
- - samsung,s3c2443-adc
- samsung,s3c6410-adc
- samsung,s5pv210-adc
- items:
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/5] dt-bindings: iio: adc: samsung,exynos: Drop touchscreen support
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
` (3 preceding siblings ...)
2025-08-30 11:09 ` [PATCH 4/5] dt-bindings: iio: adc: samsung,exynos: Drop S3C2410 Krzysztof Kozlowski
@ 2025-08-30 11:09 ` Krzysztof Kozlowski
2025-08-30 12:27 ` [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Andy Shevchenko
5 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 11:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree, Krzysztof Kozlowski
With last user of touchscreen via ADC (S3C24xx SoC) gone, drop the
unused has-touchscreen property and optional touchscreen interrupt.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/iio/adc/samsung,exynos-adc.yaml | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 73d7ba0fda1def433a97d10bce21e762a307e36c..0654f8972525bf67089fe7fd4f3ab3ff506515c3 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -42,10 +42,7 @@ properties:
maxItems: 2
interrupts:
- description:
- ADC interrupt followed by optional touchscreen interrupt.
- minItems: 1
- maxItems: 2
+ maxItems: 1
"#io-channel-cells":
const: 1
@@ -58,11 +55,6 @@ properties:
Phandle to the PMU system controller node (to access the ADC_PHY
register on Exynos3250/4x12/5250/5420/5800).
- has-touchscreen:
- description:
- If present, indicates that a touchscreen is connected and usable.
- type: boolean
-
required:
- compatible
- reg
@@ -113,15 +105,6 @@ allOf:
items:
- const: adc
- - if:
- required:
- - has-touchscreen
- then:
- properties:
- interrupts:
- minItems: 2
- maxItems: 2
-
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
` (4 preceding siblings ...)
2025-08-30 11:09 ` [PATCH 5/5] dt-bindings: iio: adc: samsung,exynos: Drop touchscreen support Krzysztof Kozlowski
@ 2025-08-30 12:27 ` Andy Shevchenko
5 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2025-08-30 12:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-iio, linux-arm-kernel,
linux-samsung-soc, linux-kernel, devicetree
On Sat, Aug 30, 2025 at 2:09 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> S3C2410 is gone from kernel, so we can drop its support and remaining
> related pieces.
> iio: adc: exynos_adc: Drop S3C2410 support
> iio: adc: exynos_adc: Drop touchscreen support
> iio: adc: exynos_adc: Drop platform data support
Reviewed-by: Andy Shevchenko <andy@kernel.org>
for patches 1-3.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support
2025-08-30 11:09 ` [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support Krzysztof Kozlowski
@ 2025-08-30 13:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-30 13:09 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Krzysztof Kozlowski, Alim Akhtar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-iio, linux-arm-kernel, linux-samsung-soc, linux-kernel,
devicetree
On 30/08/2025 13:09, Krzysztof Kozlowski wrote:
> With last user of touchscreen via ADC (S3C24xx SoC) gone, drop the
> remaining code from Samsung SoC ADC driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/iio/adc/exynos_adc.c | 196 +------------------------------------------
> 1 file changed, 1 insertion(+), 195 deletions(-)
>
I need to drop also touchscreen-s3c2410.h header.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-08-30 13:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-30 11:09 [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 1/5] iio: adc: exynos_adc: Drop S3C2410 support Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 2/5] iio: adc: exynos_adc: Drop touchscreen support Krzysztof Kozlowski
2025-08-30 13:09 ` Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 3/5] iio: adc: exynos_adc: Drop platform data support Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 4/5] dt-bindings: iio: adc: samsung,exynos: Drop S3C2410 Krzysztof Kozlowski
2025-08-30 11:09 ` [PATCH 5/5] dt-bindings: iio: adc: samsung,exynos: Drop touchscreen support Krzysztof Kozlowski
2025-08-30 12:27 ` [PATCH 0/5] iio: adc: samsung: Simplify, cleanup and drop S3C2410 Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).