From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 2/4] watchdog: s3c2410_wdt: Drop S3C2410 support
Date: Sat, 30 Aug 2025 12:18:58 +0200 [thread overview]
Message-ID: <20250830-watchdog-s3c-cleanup-v1-2-837ae94a21b5@linaro.org> (raw)
In-Reply-To: <20250830-watchdog-s3c-cleanup-v1-0-837ae94a21b5@linaro.org>
Samsung S3C2410 SoC was removed from Linux kernel in the
commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support"), in January
2023. There are no in-kernel users of samsung,s3c2410-wdt compatible
and s3c2410-wdt platform device name, so drop both. This leaves the
driver boundable only via compatibles, so drop any CONFIG_OF ifdefs.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/watchdog/s3c2410_wdt.c | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index 40901bdac42613458f93c09654353190785ff072..f65f25fcce3ecbb1739ff98245b69601dc5353d8 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -200,11 +200,6 @@ struct s3c2410_wdt {
struct regmap *pmureg;
};
-static const struct s3c2410_wdt_variant drv_data_s3c2410 = {
- .quirks = 0
-};
-
-#ifdef CONFIG_OF
static const struct s3c2410_wdt_variant drv_data_s3c6410 = {
.quirks = QUIRK_HAS_WTCLRINT_REG,
};
@@ -368,8 +363,6 @@ static const struct s3c2410_wdt_variant drv_data_exynosautov920_cl1 = {
static const struct of_device_id s3c2410_wdt_match[] = {
{ .compatible = "google,gs101-wdt",
.data = &drv_data_gs101_cl0 },
- { .compatible = "samsung,s3c2410-wdt",
- .data = &drv_data_s3c2410 },
{ .compatible = "samsung,s3c6410-wdt",
.data = &drv_data_s3c6410 },
{ .compatible = "samsung,exynos5250-wdt",
@@ -389,16 +382,6 @@ static const struct of_device_id s3c2410_wdt_match[] = {
{},
};
MODULE_DEVICE_TABLE(of, s3c2410_wdt_match);
-#endif
-
-static const struct platform_device_id s3c2410_wdt_ids[] = {
- {
- .name = "s3c2410-wdt",
- .driver_data = (unsigned long)&drv_data_s3c2410,
- },
- {}
-};
-MODULE_DEVICE_TABLE(platform, s3c2410_wdt_ids);
/* functions */
@@ -705,7 +688,6 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, struct s3c2410_wdt *wdt)
platform_get_device_id(pdev)->driver_data;
}
-#ifdef CONFIG_OF
/* Choose Exynos850/ExynosAutov9 driver data w.r.t. cluster index */
if (variant == &drv_data_exynos850_cl0 ||
variant == &drv_data_exynosautov9_cl0 ||
@@ -741,7 +723,6 @@ s3c2410_get_wdt_drv_data(struct platform_device *pdev, struct s3c2410_wdt *wdt)
return dev_err_probe(dev, -EINVAL, "wrong cluster index: %u\n", index);
}
}
-#endif
wdt->drv_data = variant;
return 0;
@@ -929,11 +910,10 @@ static DEFINE_SIMPLE_DEV_PM_OPS(s3c2410wdt_pm_ops,
static struct platform_driver s3c2410wdt_driver = {
.probe = s3c2410wdt_probe,
.shutdown = s3c2410wdt_shutdown,
- .id_table = s3c2410_wdt_ids,
.driver = {
.name = "s3c2410-wdt",
.pm = pm_sleep_ptr(&s3c2410wdt_pm_ops),
- .of_match_table = of_match_ptr(s3c2410_wdt_match),
+ .of_match_table = s3c2410_wdt_match,
},
};
--
2.48.1
next prev parent reply other threads:[~2025-08-30 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 10:18 [PATCH 0/4] watchdog: s3c2410_wdt: Simplify, cleanup and drop S3C2410 Krzysztof Kozlowski
2025-08-30 10:18 ` [PATCH 1/4] dt-bindings: watchdog: samsung-wdt: Define cluster constraints top-level Krzysztof Kozlowski
2025-09-01 20:10 ` Rob Herring (Arm)
2025-09-02 19:05 ` Guenter Roeck
2025-08-30 10:18 ` Krzysztof Kozlowski [this message]
2025-09-02 19:06 ` [PATCH 2/4] watchdog: s3c2410_wdt: Drop S3C2410 support Guenter Roeck
2025-08-30 10:18 ` [PATCH 3/4] dt-bindings: watchdog: samsung-wdt: Drop S3C2410 Krzysztof Kozlowski
2025-09-01 20:10 ` Rob Herring (Arm)
2025-09-02 19:06 ` Guenter Roeck
2025-08-30 10:19 ` [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more Krzysztof Kozlowski
2025-09-01 14:29 ` Alim Akhtar
2025-09-01 20:13 ` Rob Herring (Arm)
2025-09-02 19:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250830-watchdog-s3c-cleanup-v1-2-837ae94a21b5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).