From: Jakub Kicinski <kuba@kernel.org>
To: Brett A C Sheffield <bacs@librecast.net>
Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net,
edumazet@google.com, gregkh@linuxfoundation.org,
horms@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org, willemb@google.com
Subject: Re: [PATCH net-next v4] selftests: net: add test for ipv6 fragmentation
Date: Mon, 1 Sep 2025 08:34:27 -0700 [thread overview]
Message-ID: <20250901083427.5d9e2a1a@kernel.org> (raw)
In-Reply-To: <20250901123757.13112-1-bacs@librecast.net>
On Mon, 1 Sep 2025 12:37:14 +0000 Brett A C Sheffield wrote:
> +static int setup(void)
> +{
> + struct ifreq ifr = {
> + .ifr_name = "lo"
> + };
> + int fd = -1;
> + int ctl;
> +
> + /* we need to set MTU, so do this in a namespace to play nicely */
> + if (unshare(CLONE_NEWNET) == -1)
> + error(KSFT_FAIL, errno, "unshare");
> +
> + ctl = socket(AF_LOCAL, SOCK_STREAM, 0);
> + if (ctl == -1)
> + error(KSFT_FAIL, errno, "socket");
> +
> + /* ensure MTU is smaller than what we plan to send */
> + ifr.ifr_mtu = MTU;
> + if (ioctl(ctl, SIOCSIFMTU, &ifr) == -1)
> + error(KSFT_FAIL, errno, "ioctl: set MTU");
> +
> + disable_dad("lo");
> + interface_up(ctl, &ifr);
> +
> + close(ctl);
> + return fd;
fd is unused here
--
pw-bot: cr
prev parent reply other threads:[~2025-09-01 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 12:37 [PATCH net-next v4] selftests: net: add test for ipv6 fragmentation Brett A C Sheffield
2025-09-01 13:45 ` Willem de Bruijn
2025-09-01 15:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901083427.5d9e2a1a@kernel.org \
--to=kuba@kernel.org \
--cc=bacs@librecast.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).