[PATCH v4] net/core: Replace offensive comment in skbuff.c

[PATCH v4] net/core: Replace offensive comment in skbuff.c

[mysteryli]

From: Mystery Li <929916200@qq.com>

The original comment contained profanity to express the frustration of
dealing with a complex and resource-constrained code path. While the
sentiment is understandable, the language is unprofessional and
unnecessary.
Replace it with a more neutral and descriptive comment that maintains
the original technical context and conveys the difficulty of the
situation without the use of offensive language.
Indeed, I do not believe this will offend any particular individual or group.
Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.

Signed-off-by: "Mystery Li" <m13940358460@163.com>
---
 net/core/skbuff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ee0274417948..202c25a01f22 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -5333,7 +5333,7 @@ int skb_cow_data(struct sk_buff *skb, int tailbits, struct sk_buff **trailer)
 		    skb_has_frag_list(skb1)) {
 			struct sk_buff *skb2;
 
-			/* Fuck, we are miserable poor guys... */
+			/* This is a painfully difficult situation with limited resources... */
 			if (ntail == 0)
 				skb2 = skb_copy(skb1, GFP_ATOMIC);
 			else
-- 
2.25.1

Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c

[Willem de Bruijn]

mysteryli wrote:
> From: Mystery Li <929916200@qq.com>
> 
> The original comment contained profanity to express the frustration of
> dealing with a complex and resource-constrained code path. While the
> sentiment is understandable, the language is unprofessional and
> unnecessary.
> Replace it with a more neutral and descriptive comment that maintains
> the original technical context and conveys the difficulty of the
> situation without the use of offensive language.
> Indeed, I do not believe this will offend any particular individual or group.
> Nonetheless, it is advisable to revise any commit that appears overly emotional or rude.
> 
> Signed-off-by: "Mystery Li" <m13940358460@163.com>

You ignored the main feedback to patch v1 about invalid signed-off.

And for some reason sent the same patch again as v2 and v4.

In general old comments are left as is, even those that would perhaps
be written differently today.

Re: [PATCH v4] net/core: Replace offensive comment in skbuff.c

[Jakub Kicinski]

On Mon, 01 Sep 2025 09:32:17 -0400 Willem de Bruijn wrote:
> In general old comments are left as is, even those that would perhaps
> be written differently today.

+1 please stop resending this patch