From: Jakub Kicinski <kuba@kernel.org>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com,
Vikas Gupta <vikas.gupta@broadcom.com>,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Subject: Re: [v5, net-next 1/9] bng_en: Add initial support for RX and TX rings
Date: Mon, 1 Sep 2025 14:19:25 -0700 [thread overview]
Message-ID: <20250901141925.2a14de07@kernel.org> (raw)
In-Reply-To: <20250828184547.242496-2-bhargava.marreddy@broadcom.com>
On Thu, 28 Aug 2025 18:45:39 +0000 Bhargava Marreddy wrote:
> + bn->tx_ring_map = kcalloc(bd->tx_nr_rings, sizeof(u16),
> + GFP_KERNEL);
> +
> + if (!bn->tx_ring_map)
> + goto err_free_core;
nit: unnecessary empty line between function call and its error check
next prev parent reply other threads:[~2025-09-01 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 18:45 [v5, net-next 0/9] Add more functionality to BNGE Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 1/9] bng_en: Add initial support for RX and TX rings Bhargava Marreddy
2025-09-01 21:19 ` Jakub Kicinski [this message]
2025-08-28 18:45 ` [v5, net-next 2/9] bng_en: Add initial support for CP and NQ rings Bhargava Marreddy
2025-09-01 21:27 ` Jakub Kicinski
2025-08-28 18:45 ` [v5, net-next 3/9] bng_en: Introduce VNIC Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 4/9] bng_en: Initialise core resources Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 5/9] bng_en: Allocate packet buffers Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 6/9] bng_en: Allocate stat contexts Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 7/9] bng_en: Register rings with the firmware Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 8/9] bng_en: Register default VNIC Bhargava Marreddy
2025-08-28 18:45 ` [v5, net-next 9/9] bng_en: Configure " Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901141925.2a14de07@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).