[PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device node

[PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device node

[Yixun Lan]

sec_uart1 is not available from Linux, and no clock is implemented in
CCF framework, thus 'make dtbs_check' will pop up this warning message:

  serial@f0612000: 'clock-names' is a required property

Removing the node from device tree to silence the DT check warning.

Signed-off-by: Yixun Lan <dlan@gentoo.org>
---
This patch try to resolve the DT check warning due to
the clock for sec_uart1 is not implemented.
---
Changes in v2:
- remove sec_uart1 node instead of marking it as reserved
- Link to v1: https://lore.kernel.org/r/20250718-02-k1-uart-clock-v1-1-698e884aa717@gentoo.org
---
 arch/riscv/boot/dts/spacemit/k1.dtsi | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
index abde8bb07c95c5a745736a2dd6f0c0e0d7c696e4..3094f75ed13badfc3db333be2b3195c61f57fddf 100644
--- a/arch/riscv/boot/dts/spacemit/k1.dtsi
+++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
@@ -777,16 +777,7 @@ uart9: serial@d4017800 {
 				status = "disabled";
 			};
 
-			sec_uart1: serial@f0612000 {
-				compatible = "spacemit,k1-uart",
-					     "intel,xscale-uart";
-				reg = <0x0 0xf0612000 0x0 0x100>;
-				interrupts = <43>;
-				clock-frequency = <14857000>;
-				reg-shift = <2>;
-				reg-io-width = <4>;
-				status = "reserved"; /* for TEE usage */
-			};
+			/* sec_uart1: 0xf0612000, not available from Linux */
 		};
 
 		multimedia-bus {

---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250718-02-k1-uart-clock-0beb9ef10fe0

Best regards,
-- 
Yixun Lan

Re: [PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device node

[Vivian Wang]

On 9/2/25 20:26, Yixun Lan wrote:
> [...]
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index abde8bb07c95c5a745736a2dd6f0c0e0d7c696e4..3094f75ed13badfc3db333be2b3195c61f57fddf 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -777,16 +777,7 @@ uart9: serial@d4017800 {
>  				status = "disabled";
>  			};
>  
> -			sec_uart1: serial@f0612000 {
> -				compatible = "spacemit,k1-uart",
> -					     "intel,xscale-uart";
> -				reg = <0x0 0xf0612000 0x0 0x100>;
> -				interrupts = <43>;
> -				clock-frequency = <14857000>;
> -				reg-shift = <2>;
> -				reg-io-width = <4>;
> -				status = "reserved"; /* for TEE usage */
> -			};
> +			/* sec_uart1: 0xf0612000, not available from Linux */

I know this is going back and forth a lot but I don't think that's a
good description of what's going on.

My preference is that we just drop this node altogether, just forgetting
that this thing even exists. But if you do think we want to keep the
information we can drop the clock-frequency property too and change its
status to something like:

  status = "disabled"; /* No clock defined */

Which also silences the warning - disabled nodes are allowed to be
incomplete.

My personal opinion is that I think sec_uart1 and TEE support feels too
theoretical to be worth caring about.

Vivian "dramforever" Wang

Re: [PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device node

[Yixun Lan]

Hi Vivian,

On 20:55 Tue 02 Sep     , Vivian Wang wrote:
> 
> On 9/2/25 20:26, Yixun Lan wrote:
> > [...]
> >
> > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> > index abde8bb07c95c5a745736a2dd6f0c0e0d7c696e4..3094f75ed13badfc3db333be2b3195c61f57fddf 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> > @@ -777,16 +777,7 @@ uart9: serial@d4017800 {
> >  				status = "disabled";
> >  			};
> >  
> > -			sec_uart1: serial@f0612000 {
> > -				compatible = "spacemit,k1-uart",
> > -					     "intel,xscale-uart";
> > -				reg = <0x0 0xf0612000 0x0 0x100>;
> > -				interrupts = <43>;
> > -				clock-frequency = <14857000>;
> > -				reg-shift = <2>;
> > -				reg-io-width = <4>;
> > -				status = "reserved"; /* for TEE usage */
> > -			};
> > +			/* sec_uart1: 0xf0612000, not available from Linux */
> 
> I know this is going back and forth a lot but I don't think that's a
> good description of what's going on.
> 
> My preference is that we just drop this node altogether, just forgetting
> that this thing even exists. But if you do think we want to keep the
yes, removing the comment and completely dropping it is an option..

> information we can drop the clock-frequency property too and change its
> status to something like:
> 
>   status = "disabled"; /* No clock defined */
> 
> Which also silences the warning - disabled nodes are allowed to be
> incomplete.
no, set to 'disabled' is simply wrong, it doesn't reflect the meaning of
"unavaiable", I remembered we've rejected this before introducing the
'sec_uart1' node in the first place

> 
> My personal opinion is that I think sec_uart1 and TEE support feels too
> theoretical to be worth caring about.
> 
> Vivian "dramforever" Wang
> 

-- 
Yixun Lan (dlan)

Re: [PATCH v2] riscv: dts: spacemit: uart: remove sec_uart1 device node

[Yixun Lan]

On Tue, 02 Sep 2025 20:26:58 +0800, Yixun Lan wrote:
> sec_uart1 is not available from Linux, and no clock is implemented in
> CCF framework, thus 'make dtbs_check' will pop up this warning message:
> 
>   serial@f0612000: 'clock-names' is a required property
> 
> Removing the node from device tree to silence the DT check warning.
> 
> [...]

Applied, thanks!

[1/1] riscv: dts: spacemit: uart: remove sec_uart1 device node
      https://github.com/spacemit-com/linux/commit/0f084b221e2c5ba16eca85b3d2497f9486bd0329

Best regards,
-- 
Yixun Lan