From: hch <hch@lst.de>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <djwong@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
axboe@kernel.dk
Subject: Re: [PATCH 1/3] fs: add an enum for number of life time hints
Date: Tue, 2 Sep 2025 07:41:09 +0200 [thread overview]
Message-ID: <20250902054108.GA11431@lst.de> (raw)
In-Reply-To: <20250901105128.14987-2-hans.holmberg@wdc.com>
Looks good, but you probably want to add a few more folks that
created this constant and the header to the Cc list.
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Mon, Sep 01, 2025 at 10:52:04AM +0000, Hans Holmberg wrote:
> Add WRITE_LIFE_HINT_NR into the rw_hint enum to define the number of
> values write life time hints can be set to. This is useful for e.g.
> file systems which may want to map these values to allocation groups.
>
> Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
> ---
> include/linux/rw_hint.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/rw_hint.h b/include/linux/rw_hint.h
> index 309ca72f2dfb..adcc43042c90 100644
> --- a/include/linux/rw_hint.h
> +++ b/include/linux/rw_hint.h
> @@ -14,6 +14,7 @@ enum rw_hint {
> WRITE_LIFE_MEDIUM = RWH_WRITE_LIFE_MEDIUM,
> WRITE_LIFE_LONG = RWH_WRITE_LIFE_LONG,
> WRITE_LIFE_EXTREME = RWH_WRITE_LIFE_EXTREME,
> + WRITE_LIFE_HINT_NR,
> } __packed;
>
> /* Sparse ignores __packed annotations on enums, hence the #ifndef below. */
> --
> 2.34.1
---end quoted text---
next prev parent reply other threads:[~2025-09-02 5:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 10:52 [PATCH 0/3] xfs: hint based zone allocation improvements Hans Holmberg
2025-09-01 10:52 ` [PATCH 1/3] fs: add an enum for number of life time hints Hans Holmberg
2025-09-02 5:41 ` hch [this message]
2025-09-02 8:47 ` Hans Holmberg
2025-09-02 16:12 ` Bart Van Assche
2025-09-01 10:52 ` [PATCH 2/3] xfs: refactor hint based zone allocation Hans Holmberg
2025-09-02 5:41 ` hch
2025-09-01 10:52 ` [PATCH 3/3] xfs: adjust the hint based zone allocation policy Hans Holmberg
2025-09-02 5:42 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902054108.GA11431@lst.de \
--to=hch@lst.de \
--cc=Hans.Holmberg@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).