* [PATCH net] net: thunder_bgx: decrement cleanup index before use
@ 2025-09-01 21:33 Rosen Penev
2025-09-01 22:18 ` Vadim Fedorenko
2025-09-02 9:50 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2025-09-01 21:33 UTC (permalink / raw)
To: netdev
Cc: Sunil Goutham, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, David Daney,
moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER, open list
All paths in probe that call goto defer do so before assigning phydev
and thus it makes sense to cleanup the prior index. It also fixes a bug
where index 0 does not get cleaned up.
Fixes: b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 21495b5dce25..90c718af06c1 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1515,11 +1515,11 @@ static int bgx_init_of_phy(struct bgx *bgx)
* for phy devices we may have already found.
*/
while (lmac) {
+ lmac--;
if (bgx->lmac[lmac].phydev) {
put_device(&bgx->lmac[lmac].phydev->mdio.dev);
bgx->lmac[lmac].phydev = NULL;
}
- lmac--;
}
of_node_put(node);
return -EPROBE_DEFER;
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: thunder_bgx: decrement cleanup index before use
2025-09-01 21:33 [PATCH net] net: thunder_bgx: decrement cleanup index before use Rosen Penev
@ 2025-09-01 22:18 ` Vadim Fedorenko
2025-09-02 9:50 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-09-01 22:18 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: Sunil Goutham, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, David Daney,
moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER, open list
On 01/09/2025 22:33, Rosen Penev wrote:
> All paths in probe that call goto defer do so before assigning phydev
> and thus it makes sense to cleanup the prior index. It also fixes a bug
> where index 0 does not get cleaned up.
>
> Fixes: b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 21495b5dce25..90c718af06c1 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1515,11 +1515,11 @@ static int bgx_init_of_phy(struct bgx *bgx)
> * for phy devices we may have already found.
> */
> while (lmac) {
> + lmac--;
> if (bgx->lmac[lmac].phydev) {
> put_device(&bgx->lmac[lmac].phydev->mdio.dev);
> bgx->lmac[lmac].phydev = NULL;
> }
> - lmac--;
> }
> of_node_put(node);
> return -EPROBE_DEFER;
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: thunder_bgx: decrement cleanup index before use
2025-09-01 21:33 [PATCH net] net: thunder_bgx: decrement cleanup index before use Rosen Penev
2025-09-01 22:18 ` Vadim Fedorenko
@ 2025-09-02 9:50 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-09-02 9:50 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Sunil Goutham, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, David Daney,
moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER, open list
On Mon, Sep 01, 2025 at 02:33:14PM -0700, Rosen Penev wrote:
> All paths in probe that call goto defer do so before assigning phydev
> and thus it makes sense to cleanup the prior index. It also fixes a bug
> where index 0 does not get cleaned up.
>
> Fixes: b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
As I reviewed an earlier revision (yesterday)
where this was part of another patch:
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 21:33 [PATCH net] net: thunder_bgx: decrement cleanup index before use Rosen Penev
2025-09-01 22:18 ` Vadim Fedorenko
2025-09-02 9:50 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).