From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Kees Cook <kees@kernel.org>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: [PATCH] mm: Fix kernel stack tagging for certain configs
Date: Tue, 2 Sep 2025 10:59:03 -0700 [thread overview]
Message-ID: <20250902175903.1124555-1-vishal.moola@gmail.com> (raw)
Commit 4ef905bda61f ("mm: tag kernel stack pages") began marking pages
that were being used for the kernel stack.
There are 3 cases where kernel pages are allocated for kernel stacks:
CONFIG_VMAP_STACK, THREAD_SIZE >= PAGE_SIZE, THREAD_SIZE < PAGE_SIZE.
These cases use vmalloc(), alloc_pages() and kmem_cache_alloc()
respectively.
In the first 2 cases, THREAD_SIZE / PAGE_SIZE will always be greater
than 0, and pages are tagged as expected. In the third case,
THREAD_SIZE / PAGE_SIZE evaluates to 0 and doesn't tag any pages at all.
This meant that in those configs, the stack tagging was a no-op, and led
to smatch build warnings.
We definitely have at least 1 page we want tagged at this point, so fix
it by using a do {} while loop instead of a for loop.
Fixes: 4ef905bda61f ("mm: tag kernel stack pages")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202508300929.TrRovUMu-lkp@intel.com/
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
kernel/fork.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 1b394426ab4a..9b13cb83e1c6 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -448,14 +448,15 @@ static void account_kernel_stack(struct task_struct *tsk, int account)
} else {
void *stack = task_stack_page(tsk);
struct page *page = virt_to_head_page(stack);
- int i;
+ int i = 0;
/* All stack pages are in the same node. */
mod_lruvec_kmem_state(stack, NR_KERNEL_STACK_KB,
account * (THREAD_SIZE / 1024));
- for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++, page++)
- __SetPageStack(page);
+ do {
+ __SetPageStack(page++);
+ } while (++i < THREAD_SIZE / PAGE_SIZE);
}
}
@@ -474,10 +475,11 @@ void exit_task_stack_account(struct task_struct *tsk)
}
} else {
struct page *page = virt_to_head_page(task_stack_page(tsk));
- int i;
+ int i = 0;
- for (i = 0; i < THREAD_SIZE / PAGE_SIZE; i++, page++)
- __ClearPageStack(page);
+ do {
+ __ClearPageStack(page++);
+ } while (++i < THREAD_SIZE / PAGE_SIZE);
}
}
--
2.51.0
next reply other threads:[~2025-09-02 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 17:59 Vishal Moola (Oracle) [this message]
2025-09-02 18:23 ` [PATCH] mm: Fix kernel stack tagging for certain configs David Hildenbrand
2025-09-02 20:06 ` Vishal Moola (Oracle)
2025-09-03 7:46 ` David Hildenbrand
2025-09-03 18:12 ` Vishal Moola (Oracle)
2025-09-04 6:38 ` David Hildenbrand
2025-09-02 19:30 ` Matthew Wilcox
2025-09-02 20:09 ` Dan Carpenter
2025-09-04 6:42 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902175903.1124555-1-vishal.moola@gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=david@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).